27122[BUGFIX] No double slash during folder canonicalization
Commit message
Review
-
Code review CR +2
- Frans Saris +2
-
Verified V +2
- Frans Saris +2
Issues 1
Files 1
Review log 15
-
Mr. Jenkins commented on patch set 1 01/29/14, 10:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13309/ : SUCCESS -
Fabien Udriot commented on patch set 1 CR +1 01/29/14, 11:38
AbstractHierarchicalFilesystemDriver.php:93I tend to prefer to have one return per method. -
Alexander Stehlik uploaded patch set 2 01/29/14, 11:40
-
Alexander Stehlik commented on patch set 2 01/29/14, 11:41
Yes, this looks nicer indeed :) -
Mr. Jenkins commented on patch set 2 01/29/14, 11:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13312/ : SUCCESS -
Marcin Sągol voted on patch set 2 CR +1 01/29/14, 12:10
-
Fabien Udriot voted on patch set 2 CR +1 01/29/14, 12:31
-
Steffen Ritter commented on patch set 2 V +1 CR +2 01/29/14, 13:17
Had that, too, -
Frans Saris commented on patch set 2 01/29/14, 14:10
AbstractHierarchicalFilesystemDriver.php:96I would go for return rtrim($this->canonicalizeAndCheckFileIdentifier($folderPath), '/') . '/'; -
Alexander Stehlik commented on patch set 2 01/29/14, 14:30
AbstractHierarchicalFilesystemDriver.php:96ReplyI thought about this too, but as far as I can see the single slash is the only case when canonicalizeAndCheckFileIdentifier() will return a trailing slash. So performance wise the current solution is better because otherwise rtrim() would be used on every single run even if it is not required. -
Wouter Wolters voted on patch set 2 CR +1 01/29/14, 18:07
-
Frans Saris updated the commit message in patch set 2 01/30/14, 09:54
-
Frans Saris commented on patch set 3 V +2 CR +2 01/30/14, 09:56
Only changed typo in commit message so votes still count. -
Frans Saris merged patch set 4 01/30/14, 09:56
-
Mr. Jenkins commented on patch set 3 01/30/14, 10:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13338/ : SUCCESS