Review main Merged

27125[TASK] TemplateService: Remove old paths from allowedPaths-list

Stefan Neufeind CR +2 V +2 Easy +0 −1 updated 01/30/14, 19:12

Commit message

We don't have the t3lib-directory anymore.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1

Issues 1

Files 1

Review log 7

  1. Stefan Neufeind commented on patch set 1 01/29/14, 13:22

    TemplateService.php:360

    How about media? We don't ship media ourselves. Is that "commonly used"? If so, an option might be to mention it in the release-notes and people can add it to their addAllowedPaths themselves?
  2. Mr. Jenkins commented on patch set 1 01/29/14, 13:33

  3. Georg Ringer commented on patch set 1 V +1 01/29/14, 14:04

    TemplateService.php:362

    remove that as well if out commented
  4. Benni Mack commented on patch set 1 CR +1 01/29/14, 15:45

    TemplateService.php:360 Reply

    Hey Stefan, I have a patch to remove media/. Will do that separately, k?
  5. Stefan Neufeind commented on patch set 1 01/29/14, 15:55

    TemplateService.php:360 Reply

    As you please. Or add the full patch on your side or here. I don't mind. We can abandon the patch which is not needed anymore. Imho there is no need to have each patch just be 1 line :-) Maybe link your review in the comments and/or forge.
  6. Benni Mack commented on patch set 1 V +2 CR +2 01/30/14, 19:12

    declared as no-brainer.
  7. Benni Mack merged patch set 2 01/30/14, 19:12