27126[BUGFIX] Various PHP Warnings with invalid credentials
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
-
Verified V +2
- Stefan Neufeind +2
Issues 1
Files 2
Review log 26
Show 1 earlier messages
-
Georg Ringer voted on patch set 1 V +1 CR +1 01/29/14, 14:03
-
Mr. Jenkins commented on patch set 1 01/29/14, 14:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13319/ : SUCCESS -
Wouter Wolters voted on patch set 1 CR +1 01/29/14, 14:17
-
Marcin Sągol commented on patch set 1 01/29/14, 14:44
LoginController.php:183For each check: is_array($GLOBALS['BE_USER']->user) && $GLOBALS['BE_USER']->user['uid'] can't we just use isset($GLOBALS['BE_USER']->user['uid']) ? -
Markus Klein commented on patch set 1 01/29/14, 14:58
I'd opt to change to isset() which is faster than is_array()LoginController.php:183ReplyYes that should work! -
Xavier Perseguers commented on patch set 1 01/29/14, 15:14
LoginController.php:183Replyisset just checks the existance of the key, not that it's different from 0, so if we change we should change for empty() instead -
Markus Klein commented on patch set 1 01/29/14, 15:29
LoginController.php:183Replyyes I thought about isset($var) && $var which is of course empty($var). uid=0 is invalid anyway so empty is fine. +1 -
Marcin Sągol commented on patch set 1 01/29/14, 15:36
LoginController.php:183ReplyAgree. +1 -
Xavier Perseguers uploaded patch set 2 02/01/14, 16:39
-
Marcin Sągol commented on patch set 2 02/01/14, 16:47
LoginController.php:183Maybe replace != with !== ? -
Xavier Perseguers commented on patch set 2 02/01/14, 16:51
LoginController.php:183Replyfeel free -
Mr. Jenkins commented on patch set 2 02/01/14, 16:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13532/ : SUCCESS -
Marcin Sągol uploaded patch set 3 02/01/14, 17:08
-
Marcin Sągol commented on patch set 3 02/01/14, 17:12
Just a small comparison operator change. -
Mr. Jenkins commented on patch set 3 02/01/14, 17:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13534/ : SUCCESS -
Markus Klein voted on patch set 3 CR +1 02/01/14, 19:43
-
Stefan Neufeind commented on patch set 3 V +1 CR +1 02/01/14, 20:11
imho also 6.1 -
Oliver Klee voted on patch set 3 CR +1 02/02/14, 13:37
-
Stefano Kowalke commented on patch set 3 02/02/14, 17:31
I can't reproduce this error. Entered 1) wrong username and correct password 2) correct username and wrong password 3) complete wrong credentials -
Marcin Sągol commented on patch set 3 V +1 CR +1 02/02/14, 18:30
Works fine :) Before there was several entries generated like "Illegal string offset ...". Now only info about faild login attempt: Login-attempt from 127.0.0.1 (), username 'admin', password not accepted! -
Stefan Neufeind updated the commit message in patch set 3 02/02/14, 19:19
-
Stefan Neufeind commented on patch set 4 02/02/14, 19:21
@Stefano: By defaultthe warnings might not show for you - but they are there, because uid is not set and things like that. You could for example enable "full" errors via AdditionalConfiguration.php or the like. -
Stefan Neufeind commented on patch set 4 V +2 CR +2 02/02/14, 19:21
Added 6.1 as well. Votes still stand. -
Stefan Neufeind merged patch set 5 02/02/14, 19:22
-
Stefan Neufeind commented on patch set 5 02/02/14, 19:22
Cherry Picked This patchset was cherry picked to change: I62b85816ce04720ed9fd236965c3a6f55effd093 -
Mr. Jenkins commented on patch set 4 02/03/14, 03:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13620/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13619/ : SUCCESS