Review TYPO3_6-1 Merged

27135[BUGFIX] TSFE->altPageTitle can not be set in extensions

Wouter Wolters CR +2 V +2 Normal +50 −10 updated 02/03/14, 13:07

Commit message

It is not possible to set $GLOBALS['TSFE']->altPageTitle
in USER_INT extensions anymore to modify the page title.

This has been possible before in the 4.x branches.

Fix this by implementing the title generation like all
other header data.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • Alexander Opitz +1

Issues 1

Files 4

Review log 5

  1. Wouter Wolters uploaded patch set 2 01/29/14, 19:49

  2. Wouter Wolters updated the commit message in patch set 2 01/29/14, 19:50

  3. Alexander Opitz commented on patch set 3 V +1 01/30/14, 08:19

    TypoScriptFrontendControllerTest.php:82

    Missing a tab (Damn this is now also missing in master)
  4. Markus Klein commented on patch set 3 V +2 CR +2 02/03/14, 13:07

    Tests run fine
  5. Markus Klein merged patch set 4 02/03/14, 13:07