Review main Merged

27137[BUGFIX] Fix fatal when processing folder does not exist

Helmut Hummel CR +2 V +2 Easy +4 −3 updated 01/05/19, 17:43

Commit message

When the processing folder does not exist,
it is created on the fly in ResourceStorage.

However the returned object is at a later point
as string, leading to a fatal error in the end.

Solution is to just store the retuned object directly.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Anja Leichsenring +1
    • Marcin Sągol +1
    • Steffen Ritter +1
  • Verified V +2
    • Helmut Hummel +2
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 10

  1. Mr. Jenkins commented on patch set 1 01/29/14, 22:33

  2. Helmut Hummel uploaded patch set 2 01/05/19, 17:04

  3. Helmut Hummel uploaded patch set 3 01/05/19, 17:04

  4. Steffen Ritter voted on patch set 3 CR +1 01/05/19, 17:04

  5. Marcin Sągol voted on patch set 3 CR +1 01/05/19, 17:04

  6. Anja Leichsenring voted on patch set 3 V +1 CR +1 01/05/19, 17:04

  7. Helmut Hummel voted on patch set 3 V +2 CR +2 01/05/19, 17:04

  8. Helmut Hummel merged patch set 4 01/05/19, 17:04

  9. Mr. Jenkins commented on patch set 2 01/05/19, 17:04

  10. Mr. Jenkins commented on patch set 3 01/05/19, 17:04