Review main Merged

27147[TASK] Install Tool > All Configuration "Expand All" functionality

Marcel Küpper CR +2 V +2 Easy +20 −0 updated 01/30/14, 18:49

Commit message

Adds toggle all functionality.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Frans Saris +1
  • Verified V +2
    • Anja Leichsenring +2
    • Frans Saris +1

Issues 1

Files 3

Review log 19

  1. Wouter Wolters commented on patch set 1 CR +1 01/30/14, 12:29

    one small CGL thingy

    Install.js:311

    after function no space
  2. Anja Leichsenring commented on patch set 1 01/30/14, 12:34

    Works, but in my Browser (Chromium on Ubuntu 13.10) now the Button on the bottom is misplaced. I can not reach it to save changes.
  3. Mr. Jenkins commented on patch set 1 01/30/14, 12:40

  4. Marcel Küpper uploaded patch set 2 01/30/14, 12:43

  5. Anja Leichsenring commented on patch set 2 CR -1 01/30/14, 12:51

    still the fixed footer is misplaced and unreachable.
  6. Mr. Jenkins commented on patch set 2 01/30/14, 13:07

  7. Andreas Wolf uploaded patch set 3 01/30/14, 13:53

  8. Frans Saris commented on patch set 3 V +1 CR -1 01/30/14, 14:13

    Install.js:313

    please use length see http://api.jquery.com/size/
  9. Mr. Jenkins commented on patch set 3 01/30/14, 14:14

  10. Andreas Wolf uploaded patch set 4 01/30/14, 14:14

  11. Frans Saris voted on patch set 4 V +1 CR +1 01/30/14, 14:23

  12. Wouter Wolters voted on patch set 4 CR +1 01/30/14, 14:24

  13. Frans Saris commented on patch set 4 01/30/14, 14:25

    tested on Ubuntu 12.10 Chromium v31, Chrome v32 and FF 26
  14. Anja Leichsenring commented on patch set 4 CR +1 01/30/14, 14:25

    Code is fine. Still issues with non maximised Chromium window, but I think it is an edge case.
  15. Anja Leichsenring commented on patch set 4 V +1 01/30/14, 14:47

    works as before, my shy save button was shy before the patch.
  16. Anja Leichsenring voted on patch set 4 V +2 CR +2 01/30/14, 14:52

  17. Anja Leichsenring merged patch set 5 01/30/14, 14:52

  18. Ernesto Baschny commented on patch set 5 01/30/14, 17:09

    See and follow http://forge.typo3.org/issues/55469 for improving the design/UX of this great new feature.
  19. Mr. Jenkins commented on patch set 4 01/30/14, 18:49