Review main Merged

27163[TASK] Add CSS libs functionality for page renderer

Benni Mack CR +2 V +2 Normal +130 −26 updated 03/31/14, 19:50

Commit message

As with JS libraries, the PageRenderer should support
CSS files that should be included above CSS files.
This is necessary for e.g. normalize.css

The patch also adds the same procedure for
"includeCSSLibs" as with "includeCSSLibs" for the
frontend.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1

Issues 1

Files 3

Review log 17

  1. Anja Leichsenring voted on patch set 1 V +1 CR +1 01/30/14, 18:23

  2. Mr. Jenkins commented on patch set 1 01/30/14, 21:57

  3. Benni Mack uploaded patch set 2 01/31/14, 10:21

  4. Mr. Jenkins commented on patch set 2 01/31/14, 10:55

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 01/31/14, 14:33

  6. Anja Leichsenring uploaded patch set 3 01/31/14, 18:43

  7. Mr. Jenkins commented on patch set 3 01/31/14, 18:57

  8. Wouter Wolters commented on patch set 3 CR +1 01/31/14, 19:00

    PageGenerator.php:511

    do we still need this fix here for IE6?
  9. Wouter Wolters uploaded patch set 4 02/06/14, 16:50

  10. Wouter Wolters voted on patch set 4 V +1 CR +1 02/06/14, 16:50

  11. Mr. Jenkins commented on patch set 4 02/06/14, 17:04

  12. Anja Leichsenring voted on patch set 4 V +2 CR +2 02/06/14, 19:07

  13. Anja Leichsenring merged patch set 5 02/06/14, 19:07

  14. Francois Suter commented on patch set 5 02/06/14, 21:06

    That's for the frontend too, right? If that's the case there needs to be a documentation issue for the TSref. Actually it should have been opened beforehand and related in this patch (see http://wiki.typo3.org/CommitMessage_Format_(Git)#Commit_Message_rules_for_TYPO3_CMS)
  15. Wouter Wolters commented on patch set 5 02/06/14, 21:56

    Thanks Francois for keeping an eye on this. After Anja merged the patch I realised that there was no documentation issue for this. This is indeed for the frontend.. Backend will be done seperatly. I asked Anja if there was already an ticket for this and thought she would check if this was the case. But I'm not sure if that happened. I think there still needs to be a ticket opened for this to be included in the documentation.
  16. Benni Mack commented on patch set 5 02/07/14, 12:14

    Hey, as this was my issue in the first place, I created an issue in the documentation forge tracker after the issue was merged.
  17. Markus Klein commented on patch set 5 03/31/14, 19:50

    Not working in FE due to missing markers in other HTML templates. See: http://forge.typo3.org/issues/57467