Review main Merged

27172[TASK] Add missing logDeprecatedFunction() to getAliasForClassName()

Steffen Müller CR +2 V +2 Easy +1 −0 updated 03/09/14, 20:24

Commit message

Function is already deprecated but didn't write to
deprecation-log so far.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
  • Verified V +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1

Issues 1

Files 1

Review log 14

  1. Marcin Sągol commented on patch set 1 01/30/14, 21:25

    GeneralUtility.php:4249

    Can we replace this check is_array($aliases) && isset($aliases[0]) with !empty($aliases[0]) ?
  2. Steffen Müller uploaded patch set 2 01/30/14, 21:33

  3. Marcin Sągol voted on patch set 2 CR +1 01/30/14, 21:39

  4. Mr. Jenkins commented on patch set 1 01/31/14, 03:22

  5. Mr. Jenkins commented on patch set 2 01/31/14, 03:22

  6. Mathias Brodala voted on patch set 2 CR +1 03/06/14, 16:18

  7. Christian Kuhn voted on patch set 2 CR +1 03/07/14, 17:06

  8. Xavier Perseguers voted on patch set 2 CR +1 03/07/14, 17:08

  9. Stefan Neufeind commented on patch set 2 V -1 CR +1 03/09/14, 18:20

    Will shortly push a followup with only the deprecation-log-change in ClassLoader.php

    GeneralUtility.php:4248

    This call does not exist anymore since 0f953132194ace4926e2daa23499c9c51d1cbe23 got merged (14th Feb 2014).
  10. Stefan Neufeind uploaded patch set 3 03/09/14, 18:22

  11. Stefan Neufeind commented on patch set 3 V +1 CR +1 03/09/14, 18:23

    Easy one now. Somebody please confirm (and imho merge).
  12. Mr. Jenkins commented on patch set 3 03/09/14, 18:35

  13. Jigal van Hemert commented on patch set 3 V +2 CR +2 03/09/14, 20:24

    No-brainer
  14. Jigal van Hemert merged patch set 4 03/09/14, 20:24