Review main Merged

27197[TASK] Skip GeneralUtility::resolveBackPath() if its not necessary

Andreas Wolf CR +2 V +2 Easy +3 −0 updated 01/31/14, 16:43

Commit message

resolveBackPath() is run a couple hundred times per script run,
especially in the backend. As this method is only really necessary in a
few special cases (when a path really contains "../"), we can skip it
for all other paths with an early return.

The check is really weak (it will not skip the call for things like
"/some/dir..with..dots..inbetween/"), but this is ok because we just use
it to skip all *really* obvious cases while at best not missing *any*
legitimate use-case, which should be achieved with this commit.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1

Issues 1

Files 1

Review log 7

  1. Mr. Jenkins commented on patch set 1 01/31/14, 15:15

  2. Christian Kuhn commented on patch set 1 V -1 01/31/14, 15:50

    2 failing tests: resolveBackPathWithDataProvider with data set "one level with trailing .." resolveBackPathWithDataProvider with data set "two levels with trailing .."
  3. Andreas Wolf uploaded patch set 2 01/31/14, 16:17

  4. Mr. Jenkins commented on patch set 2 01/31/14, 16:32

  5. Jan Helke voted on patch set 2 V +1 CR +1 01/31/14, 16:42

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 01/31/14, 16:43

  7. Christian Kuhn merged patch set 3 01/31/14, 16:43