Review main Merged

27219[BUGFIX] Extbase container injection test triggers PHP bug

Christian Kuhn CR +2 V +2 Easy +7 −25 updated 01/31/14, 21:02

Commit message

PHP's reflection behaves differently in an edge case used in
extbase constructor injection.
The patch removes the specific check from tests and adds
documentation of this case.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1

Issues 2

Files 2

Review log 7

  1. Christian Kuhn commented on patch set 1 01/31/14, 20:41

    Debian wheezy PHP 5.4.4-14+deb7u7 triggers the bug.
  2. Anja Leichsenring commented on patch set 1 V +1 CR +1 01/31/14, 20:46

    not the php version in question available for me, but tests still run green.
  3. Mr. Jenkins commented on patch set 1 01/31/14, 20:51

  4. Wouter Wolters voted on patch set 1 CR +1 01/31/14, 20:53

  5. Wouter Wolters voted on patch set 1 V +1 01/31/14, 21:02

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 01/31/14, 21:02

  7. Christian Kuhn merged patch set 2 01/31/14, 21:02