Review main Merged

27236[BUGFIX] Cleanup and simplify class alias handling

Helmut Hummel CR +2 V +2 Normal +28 −116 updated 02/01/14, 21:42

Commit message

There were several issues with the implementation
of class alias handling. Most importantly the
early instance alias cache depended on TYPO3_MODE
which in turn triggered a full class cache
initialization when this cache was missing in one
context.

Additionally eval() calls needed to be used in
certain situations and the building of the cache
files introduced additional complexity.

With this change the cache for early instances
is completely removed and replaced by a simple
setAliasFoClassName() call.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Anja Leichsenring +1
    • Marcin Sągol +1
    • Andreas Wolf +1
  • Verified V +2
    • Helmut Hummel +2
    • Anja Leichsenring +1
    • Andreas Wolf +1

Issues 1

Files 2

Review log 13

  1. Helmut Hummel updated the commit message in patch set 1 02/01/14, 15:28

  2. Anja Leichsenring uploaded patch set 3 02/01/14, 15:34

  3. Anja Leichsenring commented on patch set 3 V +1 CR +1 02/01/14, 15:35

    only typos fixed.
  4. Mr. Jenkins commented on patch set 1 02/01/14, 15:39

  5. Mr. Jenkins commented on patch set 2 02/01/14, 15:55

  6. Mr. Jenkins commented on patch set 3 02/01/14, 16:06

  7. Andreas Wolf uploaded patch set 4 02/01/14, 16:40

  8. Andreas Wolf voted on patch set 4 V +1 CR +1 02/01/14, 16:42

  9. Mr. Jenkins commented on patch set 4 02/01/14, 16:58

  10. Marcin Sągol voted on patch set 4 CR +1 02/01/14, 17:21

  11. Anja Leichsenring voted on patch set 4 V +1 CR +1 02/01/14, 18:14

  12. Helmut Hummel voted on patch set 4 V +2 CR +2 02/01/14, 21:42

  13. Helmut Hummel merged patch set 5 02/01/14, 21:42