Review main Merged

27243[TASK] Speed up page ID resolving in Extbase BE

Benni Mack CR +2 V +2 Normal +62 −21 updated 03/21/14, 22:39

Commit message

Extbase does some simple calls to determine the
page ID of the current request, and does not cache it.

This costs some mySQL calls, which are unneeded
once the current page ID is found. The page ID is
now stored in the ConfigurationManager to retrieve
with a simple runtime cache.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Nicole Hummel +1
  • Verified V +2
    • Stefan Neufeind +2
    • Nicole Hummel +1

Issues 2

Files 3

Review log 22

  1. Benni Mack wrote 02/01/14, 21:51

    Topic set to "performance".
  2. Mr. Jenkins commented on patch set 1 02/01/14, 22:21

  3. Wouter Wolters voted on patch set 1 CR +1 02/02/14, 20:44

  4. Michiel Roos commented on patch set 1 02/03/14, 12:20

    Since you expect cache hits on this method, please use an early return in case the currentPageId IS set.

    BackendConfigurationManager.php:136

    Since you expect cache hits on this method, please use an early return in case the currentPageId IS set.

    BackendConfigurationManager.php:144

    This will do horrible for sites with multiple site roots. But that may be a fix for a separate issue.
  5. Oliver Klee commented on patch set 1 02/03/14, 14:27

    I'm going to update the patch in a minute.

    BackendConfigurationManager.php:136

    $currentPageId is an integer with a default value of NULL. So this condition should be === NULL.
  6. Oliver Klee commented on patch set 1 CR -1 02/03/14, 14:31

    This change breaks the unit tests for the BackEndConfigurationManager.
  7. Oliver Klee voted on patch set 1 V -1 CR 0 02/03/14, 14:31

  8. Oliver Klee uploaded patch set 2 02/03/14, 14:42

  9. Oliver Klee commented on patch set 2 V -1 02/03/14, 14:43

    I've updated the patch. The unit tests still need to be adapted to the new behavior (or the code needs to be fixed to get the unit tests green again). Would someone be willing to take over?
  10. Mr. Jenkins commented on patch set 2 02/03/14, 17:07

  11. Nicole Hummel uploaded patch set 3 03/20/14, 22:22

  12. Nicole Hummel commented on patch set 3 03/20/14, 22:22

  13. Mr. Jenkins commented on patch set 3 03/20/14, 22:45

  14. Nicole Hummel uploaded patch set 4 03/20/14, 22:53

  15. Nicole Hummel commented on patch set 4 V +1 CR +1 03/20/14, 22:56

    Fixed unit tests
  16. Mr. Jenkins commented on patch set 4 03/20/14, 23:04

  17. Nicole Hummel updated the commit message in patch set 4 03/21/14, 21:59

  18. Nicole Hummel commented on patch set 5 V +1 CR +1 03/21/14, 21:59

    Removed WIP
  19. Stefan Neufeind commented on patch set 5 V +2 CR +2 03/21/14, 22:08

    test works; a demo-CLI-ext also seems to still work fine for me; discussed with Nicole
  20. Stefan Neufeind merged patch set 6 03/21/14, 22:08

  21. Mr. Jenkins commented on patch set 5 03/21/14, 22:11

  22. Oliver Hader commented on patch set 6 03/21/14, 22:39

    Post +1 on reading