27256[TASK] Use stat() instead of filemtime + filesize
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Stefan Neufeind +1
- Karol Lamparski +1
- Michiel Roos +1
- Marcin Sągol +1
- Michał Jankiewicz +1
-
Verified V +2
- Markus Klein +2
- Michiel Roos +1
Issues 1
Files 5
Review log 36
Show 11 earlier messages
-
Benni Mack commented on patch set 1 CR -1 02/02/14, 11:09
your patch removes ContentObjectRenderer - ? -
Michiel Roos commented on patch set 1 02/02/14, 13:31
Ups -
Michiel Roos uploaded patch set 2 02/02/14, 13:33
-
Mr. Jenkins commented on patch set 1 02/02/14, 15:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13569/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13568/ : SUCCESS -
Stefan Neufeind commented on patch set 2 02/02/14, 20:36
AbstractSpriteHandler.php:93no need for the double parenthesis -
Mr. Jenkins commented on patch set 2 02/02/14, 21:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13593/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13592/ : SUCCESS -
Michiel Roos wrote 02/02/14, 23:26
Topic set to "performance". -
Markus Klein updated the commit message in patch set 2 02/03/14, 23:16
-
Markus Klein commented on patch set 3 02/03/14, 23:18
AbstractSpriteHandler.php:93superfluous ()AbstractSpriteHandler.php:94Do we have any chance to getting speaking names (predefined constants) for the 9 and the 7? -
Stefan Neufeind uploaded patch set 4 02/04/14, 00:41
-
Stefan Neufeind commented on patch set 4 02/04/14, 00:43
removed double-brackets Markus pointed out and switched from numbers to associative array-indices (mtime and size), as per documentation for stat()
-
Stefan Neufeind voted on patch set 4 CR +1 02/04/14, 00:43
-
Mr. Jenkins commented on patch set 3 02/04/14, 00:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13684/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13683/ : SUCCESS -
Mr. Jenkins commented on patch set 4 02/04/14, 01:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13685/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13684/ : SUCCESS -
Michiel Roos commented on patch set 4 02/04/14, 07:17
Is there no associative index for fileInfo[10] ?Indexer.php:1170Is there no associative index for fileInfo[10] ? -
Stefan Neufeind uploaded patch set 5 02/04/14, 08:22
-
Stefan Neufeind commented on patch set 5 CR +1 02/04/14, 08:24
@Michiel: Rhetorical question ... of course there is :-) -
Michiel Roos voted on patch set 5 V +1 CR +1 02/04/14, 08:32
-
Mr. Jenkins commented on patch set 5 02/04/14, 08:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13689/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13688/ : SUCCESS -
Michał Jankiewicz uploaded patch set 6 02/08/14, 12:32
-
Mr. Jenkins commented on patch set 6 02/08/14, 13:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13815/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13814/ : SUCCESS -
Markus Klein commented on patch set 6 CR -1 02/08/14, 13:14
Huh, what happened here? You removed all the other changes? -
Michał Jankiewicz commented on patch set 6 02/08/14, 13:40
upps sorry, I will upload correct patch -
Michał Jankiewicz uploaded patch set 7 02/08/14, 14:20
-
Michał Jankiewicz commented on patch set 7 V +1 CR +1 02/08/14, 14:44
We should check performance on bigger amount data -
Marcin Sągol voted on patch set 7 CR +1 02/08/14, 15:28
-
Markus Klein commented on patch set 7 02/08/14, 16:07
@MJ: Would you mind changing your user settings to contain your real name? We usually use real names here. thank you -
Michał Jankiewicz commented on patch set 7 V 0 CR 0 02/08/14, 16:11
sure, I've changed -
Karol Lamparski voted on patch set 7 CR +1 02/08/14, 16:34
-
Markus Klein voted on patch set 7 CR +1 02/08/14, 17:05
-
Michał Jankiewicz voted on patch set 7 CR +1 02/08/14, 17:23
-
Mr. Jenkins commented on patch set 7 02/08/14, 20:03
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13836/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13835/ : SUCCESS -
Stefan Neufeind voted on patch set 7 CR +1 02/08/14, 20:12
-
Michiel Roos voted on patch set 7 V +1 CR +1 02/09/14, 06:16
-
Markus Klein voted on patch set 7 V +2 CR +2 02/10/14, 12:17
-
Markus Klein merged patch set 8 02/10/14, 12:17