Review main Merged

27256[TASK] Use stat() instead of filemtime + filesize

Michiel Roos CR +2 V +2 Easy +25 −18 updated 02/10/14, 12:17

Commit message

Calling stat() is cheaper than calling filemtime() AND filesize().

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Karol Lamparski +1
    • Michiel Roos +1
    • Marcin Sągol +1
    • Michał Jankiewicz +1
  • Verified V +2
    • Markus Klein +2
    • Michiel Roos +1

Issues 1

Files 5

Review log 36

Show 11 earlier messages
  1. Benni Mack commented on patch set 1 CR -1 02/02/14, 11:09

    your patch removes ContentObjectRenderer - ?
  2. Michiel Roos commented on patch set 1 02/02/14, 13:31

    Ups
  3. Michiel Roos uploaded patch set 2 02/02/14, 13:33

  4. Mr. Jenkins commented on patch set 1 02/02/14, 15:23

  5. Stefan Neufeind commented on patch set 2 02/02/14, 20:36

    AbstractSpriteHandler.php:93

    no need for the double parenthesis
  6. Mr. Jenkins commented on patch set 2 02/02/14, 21:29

  7. Michiel Roos wrote 02/02/14, 23:26

    Topic set to "performance".
  8. Markus Klein updated the commit message in patch set 2 02/03/14, 23:16

  9. Markus Klein commented on patch set 3 02/03/14, 23:18

    AbstractSpriteHandler.php:93

    superfluous ()

    AbstractSpriteHandler.php:94

    Do we have any chance to getting speaking names (predefined constants) for the 9 and the 7?
  10. Stefan Neufeind uploaded patch set 4 02/04/14, 00:41

  11. Stefan Neufeind commented on patch set 4 02/04/14, 00:43

    removed double-brackets Markus pointed out and switched from numbers to associative array-indices (mtime and size), as per documentation for stat()
  1. Stefan Neufeind voted on patch set 4 CR +1 02/04/14, 00:43

  2. Mr. Jenkins commented on patch set 3 02/04/14, 00:57

  3. Mr. Jenkins commented on patch set 4 02/04/14, 01:11

  4. Michiel Roos commented on patch set 4 02/04/14, 07:17

    Is there no associative index for fileInfo[10] ?

    Indexer.php:1170

    Is there no associative index for fileInfo[10] ?
  5. Stefan Neufeind uploaded patch set 5 02/04/14, 08:22

  6. Stefan Neufeind commented on patch set 5 CR +1 02/04/14, 08:24

    @Michiel: Rhetorical question ... of course there is :-)
  7. Michiel Roos voted on patch set 5 V +1 CR +1 02/04/14, 08:32

  8. Mr. Jenkins commented on patch set 5 02/04/14, 08:36

  9. Michał Jankiewicz uploaded patch set 6 02/08/14, 12:32

  10. Mr. Jenkins commented on patch set 6 02/08/14, 13:00

  11. Markus Klein commented on patch set 6 CR -1 02/08/14, 13:14

    Huh, what happened here? You removed all the other changes?
  12. Michał Jankiewicz commented on patch set 6 02/08/14, 13:40

    upps sorry, I will upload correct patch
  13. Michał Jankiewicz uploaded patch set 7 02/08/14, 14:20

  14. Michał Jankiewicz commented on patch set 7 V +1 CR +1 02/08/14, 14:44

    We should check performance on bigger amount data
  15. Marcin Sągol voted on patch set 7 CR +1 02/08/14, 15:28

  16. Markus Klein commented on patch set 7 02/08/14, 16:07

    @MJ: Would you mind changing your user settings to contain your real name? We usually use real names here. thank you
  17. Michał Jankiewicz commented on patch set 7 V 0 CR 0 02/08/14, 16:11

    sure, I've changed
  18. Karol Lamparski voted on patch set 7 CR +1 02/08/14, 16:34

  19. Markus Klein voted on patch set 7 CR +1 02/08/14, 17:05

  20. Michał Jankiewicz voted on patch set 7 CR +1 02/08/14, 17:23

  21. Mr. Jenkins commented on patch set 7 02/08/14, 20:03

  22. Stefan Neufeind voted on patch set 7 CR +1 02/08/14, 20:12

  23. Michiel Roos voted on patch set 7 V +1 CR +1 02/09/14, 06:16

  24. Markus Klein voted on patch set 7 V +2 CR +2 02/10/14, 12:17

  25. Markus Klein merged patch set 8 02/10/14, 12:17