27257[TASK] Add FileCollectionRegistry
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 4
Review log 32
Show 7 earlier messages
-
Frans Saris uploaded patch set 2 02/02/14, 10:16
-
Frans Saris commented on patch set 2 02/02/14, 10:17
See forge for instruction on how to register your own type -
Stefan Froemken commented on patch set 2 V +1 CR -1 02/02/14, 11:15
Patch works good, but there are some wording problems in Code and I miss a testcase.FileCollectionRegistry.php:38It constructs this object or it registers the file collection classes, but it does not creates this objectFileCollectionRegistry.php:48Add an empty row between description and @paramFileCollectionRegistry.php:65It's a collection, not a driverFileCollectionRegistry.php:81I miss a little description hereFileCollectionRegistry.php:91I'm not sure. Doesn't we have spaces between "."FileCollectionRegistryTest.php:149There is no test for addTypeToTCA -
Frans Saris uploaded patch set 3 02/02/14, 13:46
-
Frans Saris commented on patch set 2 02/02/14, 13:46
FileCollectionRegistry.php:38ReplyDoneFileCollectionRegistry.php:48ReplyDoneFileCollectionRegistry.php:65ReplyDoneFileCollectionRegistry.php:81ReplyDoneFileCollectionRegistry.php:91ReplyDone -
Frans Saris uploaded patch set 4 02/02/14, 14:02
-
Frans Saris commented on patch set 2 02/02/14, 14:03
FileCollectionRegistryTest.php:149ReplyDone
-
Mr. Jenkins commented on patch set 1 02/02/14, 16:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13572/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13571/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/02/14, 16:26
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13573/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13572/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/02/14, 21:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13595/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13594/ : SUCCESS -
Mr. Jenkins commented on patch set 4 02/02/14, 22:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13597/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13596/ : SUCCESS -
Stefan Froemken voted on patch set 4 V +1 CR +1 02/03/14, 08:59
-
Wouter Wolters commented on patch set 4 02/03/14, 16:55
FileCollectionRegistry.php:15one tab too muchFileCollectionRegistry.php:49missing types here for some parametersFileCollectionRegistry.php:73space after elseifFileCollectionRegistry.php:126spaces around .$type. -
Frans Saris uploaded patch set 5 02/12/14, 19:11
-
Frans Saris commented on patch set 4 02/12/14, 19:12
FileCollectionRegistry.php:15ReplyDoneFileCollectionRegistry.php:49ReplyDoneFileCollectionRegistry.php:73ReplyDoneFileCollectionRegistry.php:126ReplyDone -
Mr. Jenkins commented on patch set 5 02/12/14, 19:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14020/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14019/ : SUCCESS -
Markus Klein updated the commit message in patch set 5 02/16/14, 14:09
-
Mr. Jenkins commented on patch set 6 02/16/14, 14:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14079/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14078/ : SUCCESS -
Markus Klein commented on patch set 6 CR -1 02/16/14, 14:47
I made an extensive review.This desperately needs proper documentation. So please add a ticket and reference it here.FileCollectionRegistry.php:35phpdoc missingFileCollectionRegistry.php:51override what? Description pleaseFileCollectionRegistry.php:52registering -> registrationFileCollectionRegistry.php:5830 bytes.FileCollectionRegistry.php:65escaping for \ missing: \\FileCollectionRegistry.php:111why not simply use empty()? is this faster?FileCollectionRegistry.php:112Only use that function if you really need the UNSET feature of it. otherwise use the PHP functionFileCollectionRegistry.php:137rename it to fileCollectionTypeExistsFileCollectionRegistryTest.php:28remove indentationFileCollectionRegistryTest.php:32no need for the full namespace, we're in the same already.FileCollectionRegistryTest.php:37call it $subject. Fixture is something else. See also commit message from Oli Klee in phpunit and phpunit docs. This was a mistake introduced in the beginning of unit tests in Core and should be changed step by step.FileCollectionRegistryTest.php:61we're usually using the @expectedException annotation for the testFileCollectionRegistryTest.php:68IsTooLongFileCollectionRegistryTest.php:89convention is that the test name starts with method name under test. registerFileCollectionClassOverridesExistingRegisteredFileCollectionClassFileCollectionRegistryTest.php:137function names start lowercasedFileCollectionRegistryTest.php:145closing ) can be on same line.FileCollectionRegistryTest.php:156use variables for the static strings to avoid code duplication below.FileCollectionRegistryTest.php:171Only used once. Put it into test directly. Makes it easier to read the test. -
Frans Saris commented on patch set 6 02/17/14, 08:25
Reply
DoneFileCollectionRegistry.php:35ReplyDoneFileCollectionRegistry.php:51ReplyDoneFileCollectionRegistry.php:52ReplyDoneFileCollectionRegistry.php:58ReplyDoneFileCollectionRegistry.php:65ReplyDoneFileCollectionRegistry.php:111ReplyThis is faster/cleanerFileCollectionRegistry.php:112ReplyThe intention of this functionality is that you can override some thing so I think it is okay to use it here. Also the result is cached in the TCA cache so this is only executed when TCA cache is cleared.FileCollectionRegistry.php:137ReplyDoneFileCollectionRegistryTest.php:28ReplyDoneFileCollectionRegistryTest.php:61ReplyBut then I can not check for the exception code can I?FileCollectionRegistryTest.php:68ReplyDoneFileCollectionRegistryTest.php:89ReplyDid that to prevent to long names. doneFileCollectionRegistryTest.php:137ReplyDoneFileCollectionRegistryTest.php:145ReplyDoneFileCollectionRegistryTest.php:156ReplyDoneFileCollectionRegistryTest.php:171ReplyDone -
Frans Saris uploaded patch set 7 02/17/14, 08:25
-
Mr. Jenkins commented on patch set 7 02/17/14, 08:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14091/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14090/ : SUCCESS -
Markus Klein commented on patch set 7 02/17/14, 09:43
FileCollectionRegistryTest.php:62http://phpunit.de/manual/current/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.exceptions @expectedExceptionMessage and @expectedExceptionCode exist as well I'd really suggest to use these as we should stay consistent within the Core.FileCollectionRegistryTest.php:138FileCollectionTypeExists -> fileCollectionTypeExists -
Frans Saris uploaded patch set 8 02/17/14, 09:53
-
Frans Saris commented on patch set 7 02/17/14, 09:53
FileCollectionRegistryTest.php:62ReplyDoneFileCollectionRegistryTest.php:138ReplyDone -
Mr. Jenkins commented on patch set 8 02/17/14, 10:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14099/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14098/ : SUCCESS -
Markus Klein voted on patch set 8 CR +1 02/17/14, 10:51
-
Markus Klein voted on patch set 8 V +1 02/17/14, 12:37
-
Wouter Wolters commented on patch set 8 CR +1 02/17/14, 19:49
FileCollectionRegistry.php:63bytes -> characters?FileCollectionRegistry.php:67double quotes around the className? -
Frans Saris commented on patch set 8 02/17/14, 19:58
FileCollectionRegistry.php:63Replyphp.net: strlen() returns the number of bytes rather than the number of characters in a stringFileCollectionRegistry.php:67ReplyIs not used on other places so do not think we should use it here. Code is inspired from DriverRegistry -
Wouter Wolters voted on patch set 8 V +2 CR +2 02/17/14, 20:04
-
Wouter Wolters merged patch set 9 02/17/14, 20:04