Review main Merged

27267[TASK] Style "Download" button - element information

Felix Kopp CR +2 V +2 Easy +2 −1 updated 02/03/14, 00:00

Commit message

Brings button style to "Download" link with download icon.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Marcin Sągol +1
  • Verified V +2
    • Wouter Wolters +2
    • Marcin Sągol +1

Issues 1

Files 1

Review log 11

  1. Felix Kopp commented on patch set 1 02/02/14, 15:28

    Depends on 27266
  2. Marcin Sągol commented on patch set 1 CR +1 02/02/14, 15:53

    Where exactly i can see/check this change ?
  3. Felix Kopp commented on patch set 1 02/02/14, 15:57

    Bllue (i) icon on file in filelist - popup above table
  4. Wouter Wolters commented on patch set 1 02/02/14, 16:10

    Felix: Where is this sprite defined? Search in the core doesn't give me any result..
  5. Wouter Wolters commented on patch set 1 02/02/14, 16:12

    never mind, I see the depending ticket now..
  6. Marcin Sągol commented on patch set 1 02/02/14, 16:13

    Wouter does the icon on the button works for you with related patch? I see only red circle with questionmark.
  7. Wouter Wolters commented on patch set 1 V +1 CR +1 02/02/14, 16:14

    Marcin, remove typo3temp/sprites and refresh the comlete backend. Recheck;)
  8. Marcin Sągol voted on patch set 1 V +1 02/02/14, 16:17

  9. Wouter Wolters voted on patch set 1 V +2 CR +2 02/02/14, 16:21

  10. Wouter Wolters merged patch set 2 02/02/14, 16:21

  11. Mr. Jenkins commented on patch set 1 02/03/14, 00:00