Review main Merged

27270[TASK] tabmenu: Get rid of mouseOver/mouseOut

Stefan Neufeind CR +2 V +2 Normal +20 −65 updated 02/03/14, 01:51

Commit message

Tabmenu so far used mouseOver/mouseOut to set CSS-classes.
This is replaced with :hover functionality.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Marcin Sągol +1
  • Verified V +2
    • Christian Kuhn +2
    • Marcin Sągol +1

Issues 1

Files 4

Review log 9

  1. Marcin Sągol voted on patch set 1 CR +1 02/02/14, 16:59

  2. Stefan Neufeind commented on patch set 1 V -1 02/02/14, 17:00

    Elements seem to fail to initialise. Will push a follow-up soon.
  3. Stefan Neufeind uploaded patch set 2 02/02/14, 17:06

  4. Stefan Neufeind commented on patch set 2 02/02/14, 17:06

    Was just a one-character typo (comma vs. semicolon) during last-minute-cleanup that caused tabmenu.js to fail to initialise then. Works for me now.
  5. Marcin Sągol voted on patch set 2 V +1 CR +1 02/02/14, 17:14

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 02/02/14, 20:23

  7. Christian Kuhn merged patch set 3 02/02/14, 20:23

  8. Mr. Jenkins commented on patch set 1 02/03/14, 01:24

  9. Mr. Jenkins commented on patch set 2 02/03/14, 01:51