27286[TASK] Cleanup ext_localconf.php of sysexts
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
- Fabien Udriot +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
- Fabien Udriot +1
Issues 1
Files 13
- typo3/sysext/cms/ext_localconf.php1+183 −176
- typo3/sysext/css_styled_content/ext_localconf.php2+3 −27
- typo3/sysext/extbase/ext_localconf.php+13 −13
- typo3/sysext/feedit/ext_localconf.php+3 −1
- typo3/sysext/felogin/ext_localconf.php2+14 −11
- typo3/sysext/recycler/ext_localconf.php+3 −1
- typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaBase.php+2 −0
- typo3/sysext/rtehtmlarea/res/indentalign/pageTSConfig.txtdeleted+0 −13
- typo3/sysext/rtehtmlarea/ext_localconf.php1+2 −57
- typo3/sysext/setup/ext_tables.php+140 −139
- typo3/sysext/sys_note/ext_localconf.php+3 −3
- typo3/sysext/taskcenter/ext_tables.php+2 −2
- typo3/sysext/workspaces/ext_localconf.php+5 −3
Review log 33
Show 8 earlier messages
-
Mr. Jenkins commented on patch set 1 02/03/14, 06:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13629/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13628/ : SUCCESS -
Christian Kuhn commented on patch set 1 02/03/14, 11:03
This probably breaks feedit, right? Since I'm not a fan of feedit for other reasons anyway, I'll now raise a discussion about that in the core list. -
Michiel Roos commented on patch set 1 02/03/14, 12:15
Can you 'resolve' the $_EXTKEY in all localconfs? This will save some string concatenation and variable substitution.ext_localconf.php:14Can you 'resolve' the $_EXTKEY in all localconfs? This will save some string concatenation and variable substitution. -
Fabien Udriot uploaded patch set 2 02/11/14, 09:44
-
Fabien Udriot commented on patch set 2 V +1 02/11/14, 09:46
Rebased patch #2. No side effects noticed in the BE nor in the FE. However Christian K, pointed that it could break "feedit". -
Mr. Jenkins commented on patch set 2 02/11/14, 10:10
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13965/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13964/ : SUCCESS -
Susi Moog commented on patch set 2 V +1 CR +1 02/12/14, 15:50
Seems like it does not break feedit after all, just tested some simple cases, works fine - since there is no inline editing in feedit anymore. -
Fabien Udriot uploaded patch set 3 02/20/14, 17:27
-
Fabien Udriot commented on patch set 3 V +1 CR +1 02/20/14, 17:28
Just rebasing patch -
Mr. Jenkins commented on patch set 3 02/20/14, 17:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14204/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14203/ : SUCCESS -
Michiel Roos commented on patch set 3 CR -1 02/20/14, 19:24
Please resolve all $_EXTKEY since they are know values. It's nonsense to have PHP do that over and over again for each request that reads the cached ext_localconf.php filesext_localconf.php:46Please resolve all $_EXTKEY since they are know values. It's nonsense to have PHP do that over and over again for each request that reads the cached ext_localconf.php files. -
Benni Mack uploaded patch set 4 02/26/14, 12:47
-
Mr. Jenkins commented on patch set 4 02/26/14, 13:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14329/ : SUCCESS -
Fabien Udriot commented on patch set 4 02/26/14, 16:08
Remark from Michiel is not addressed... See above. -
Helmut Hummel rebased onto patch set 4 02/27/14, 16:22
-
Mr. Jenkins commented on patch set 5 02/27/14, 16:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14397/ : SUCCESS -
Frans Saris commented on patch set 5 02/27/14, 17:27
ext_localconf.php:7As this is a cleanup patch. Shouldn't this be If (!$_EXTCONF || $_EXTCONF['setPageTSconfig']) -
Wouter Wolters uploaded patch set 6 02/27/14, 20:29
-
Wouter Wolters voted on patch set 6 CR +1 02/27/14, 20:29
-
Mr. Jenkins commented on patch set 6 02/27/14, 20:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14404/ : SUCCESS -
Frans Saris commented on patch set 6 02/28/14, 18:44
ext_localconf.php:10Same here :) -
Georg Ringer uploaded patch set 7 03/13/14, 07:55
-
Mr. Jenkins commented on patch set 7 03/13/14, 08:10
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15022/ : SUCCESS -
Markus Klein commented on patch set 7 CR +1 03/13/14, 09:36
ext_localconf.php:75We can remove the method then too I guess. -
Xavier Perseguers voted on patch set 7 CR +1 03/17/14, 17:06
-
Markus Klein uploaded patch set 8 03/18/14, 10:16
-
Markus Klein voted on patch set 8 V +1 CR +1 03/18/14, 10:18
-
Mr. Jenkins commented on patch set 8 03/18/14, 10:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15250/ : SUCCESS -
Fabien Udriot voted on patch set 8 V +1 CR +1 03/18/14, 12:51
-
Wouter Wolters voted on patch set 8 V +2 CR +2 03/18/14, 18:53
-
Wouter Wolters merged patch set 9 03/18/14, 18:53
-
Marc Bastian Heinrichs commented on patch set 9 03/19/14, 09:10
Follow-Up to revert the extbase change https://review.typo3.org/#/c/28519/ -
Markus Klein commented on patch set 9 04/29/14, 16:48
ext_localconf.php:6Regression: Kills feeditadvanced http://forge.typo3.org/issues/58338