Review main Merged

27286[TASK] Cleanup ext_localconf.php of sysexts

Benni Mack CR +2 V +2 Hard +373 −446 updated 04/29/14, 16:48

Commit message

As TYPO3 is loading all ext_localconf.php on each call,
the existing code can be cleaned up by removing
old information, putting BE-only functionality in
TYPO3_MODE == 'BE' and install-tool only
in Install only mode.

Also, some hardcoded require_once statements are
removed.

Benefits are that FE does not need to load everything
all the time.

I haven't noticed any side-effects so far, but please
test extensively.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Fabien Udriot +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Fabien Udriot +1

Issues 1

Files 13

Review log 33

Show 8 earlier messages
  1. Mr. Jenkins commented on patch set 1 02/03/14, 06:47

  2. Christian Kuhn commented on patch set 1 02/03/14, 11:03

    This probably breaks feedit, right? Since I'm not a fan of feedit for other reasons anyway, I'll now raise a discussion about that in the core list.
  3. Michiel Roos commented on patch set 1 02/03/14, 12:15

    Can you 'resolve' the $_EXTKEY in all localconfs? This will save some string concatenation and variable substitution.

    ext_localconf.php:14

    Can you 'resolve' the $_EXTKEY in all localconfs? This will save some string concatenation and variable substitution.
  4. Fabien Udriot uploaded patch set 2 02/11/14, 09:44

  5. Fabien Udriot commented on patch set 2 V +1 02/11/14, 09:46

    Rebased patch #2. No side effects noticed in the BE nor in the FE. However Christian K, pointed that it could break "feedit".
  6. Mr. Jenkins commented on patch set 2 02/11/14, 10:10

  7. Susi Moog commented on patch set 2 V +1 CR +1 02/12/14, 15:50

    Seems like it does not break feedit after all, just tested some simple cases, works fine - since there is no inline editing in feedit anymore.
  8. Fabien Udriot uploaded patch set 3 02/20/14, 17:27

  1. Fabien Udriot commented on patch set 3 V +1 CR +1 02/20/14, 17:28

    Just rebasing patch
  2. Mr. Jenkins commented on patch set 3 02/20/14, 17:55

  3. Michiel Roos commented on patch set 3 CR -1 02/20/14, 19:24

    Please resolve all $_EXTKEY since they are know values. It's nonsense to have PHP do that over and over again for each request that reads the cached ext_localconf.php files

    ext_localconf.php:46

    Please resolve all $_EXTKEY since they are know values. It's nonsense to have PHP do that over and over again for each request that reads the cached ext_localconf.php files.
  4. Benni Mack uploaded patch set 4 02/26/14, 12:47

  5. Mr. Jenkins commented on patch set 4 02/26/14, 13:02

  6. Fabien Udriot commented on patch set 4 02/26/14, 16:08

    Remark from Michiel is not addressed... See above.
  7. Helmut Hummel rebased onto patch set 4 02/27/14, 16:22

  8. Mr. Jenkins commented on patch set 5 02/27/14, 16:35

  9. Frans Saris commented on patch set 5 02/27/14, 17:27

    ext_localconf.php:7

    As this is a cleanup patch. Shouldn't this be If (!$_EXTCONF || $_EXTCONF['setPageTSconfig'])
  10. Wouter Wolters uploaded patch set 6 02/27/14, 20:29

  11. Wouter Wolters voted on patch set 6 CR +1 02/27/14, 20:29

  12. Mr. Jenkins commented on patch set 6 02/27/14, 20:42

  13. Frans Saris commented on patch set 6 02/28/14, 18:44

    ext_localconf.php:10

    Same here :)
  14. Georg Ringer uploaded patch set 7 03/13/14, 07:55

  15. Mr. Jenkins commented on patch set 7 03/13/14, 08:10

  16. Markus Klein commented on patch set 7 CR +1 03/13/14, 09:36

    ext_localconf.php:75

    We can remove the method then too I guess.
  17. Xavier Perseguers voted on patch set 7 CR +1 03/17/14, 17:06

  18. Markus Klein uploaded patch set 8 03/18/14, 10:16

  19. Markus Klein voted on patch set 8 V +1 CR +1 03/18/14, 10:18

  20. Mr. Jenkins commented on patch set 8 03/18/14, 10:47

  21. Fabien Udriot voted on patch set 8 V +1 CR +1 03/18/14, 12:51

  22. Wouter Wolters voted on patch set 8 V +2 CR +2 03/18/14, 18:53

  23. Wouter Wolters merged patch set 9 03/18/14, 18:53

  24. Marc Bastian Heinrichs commented on patch set 9 03/19/14, 09:10

    Follow-Up to revert the extbase change https://review.typo3.org/#/c/28519/
  25. Markus Klein commented on patch set 9 04/29/14, 16:48

    ext_localconf.php:6

    Regression: Kills feeditadvanced http://forge.typo3.org/issues/58338