Review main Merged

27300[BUGFIX] Framework Packages aren't sorted properly

Thomas Maroschik CR +2 V +2 Easy +10 −10 updated 02/04/14, 09:04

Commit message

In the package dependency resolver, the method
buildDependencyGraph builds the dependency graph
first for the framework packages and afterwards
for all left packages.

The filtering if a package is a framework package
happens by comparing the package path with PATH_typo3
and a sysext folder contant. But as PATH_typo3 is
absolute and the package path from the package states
configuration is relative to PATH_site, this filter
does not work.

The patch changes the path to a relativ one.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Markus Klein +1
    • Stefan Froemken +1
  • Verified V +2
    • Anja Leichsenring +2
    • Markus Klein +1
    • Stefan Froemken +1

Files 2

Review log 8

  1. Markus Klein commented on patch set 1 V +1 CR +1 02/03/14, 13:34

    No-brainer! Thx Tom!!!
  2. Stefan Froemken commented on patch set 1 V +1 CR +1 02/03/14, 13:42

    Works for me. Thank you
  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 02/03/14, 13:48

  4. Anja Leichsenring merged patch set 2 02/03/14, 13:48

  5. Tymoteusz Motylewski commented on patch set 2 02/03/14, 16:34

    will it also work if sb override a core package in typo3conf/ext/ ?
  6. Mr. Jenkins commented on patch set 1 02/03/14, 16:39

  7. Markus Klein commented on patch set 2 02/03/14, 16:54

    Nope. Please open a new ticket for this and add me as watcher.
  8. Tymoteusz Motylewski commented on patch set 2 02/04/14, 09:04