27357[BUGFIX] Use count on storage after initialization of LazyObjectStorage
Commit message
Review
-
Code review CR +2
- Marc Bastian Heinrichs +2
- Stefan Neufeind +1
- Wouter Wolters +1
- Nico de Haen +1
- Marcin Sągol +1
-
Verified V +2
- Marc Bastian Heinrichs +2
- Nico de Haen +1
- Peter Beernink +1
Issues 1
Files 1
Review log 11
-
Marc Bastian Heinrichs wrote 02/05/14, 12:47
Topic set to "extbase". -
Mr. Jenkins commented on patch set 1 02/05/14, 13:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13722/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13721/ : SUCCESS -
Wouter Wolters voted on patch set 1 CR +1 02/05/14, 15:57
-
Nico de Haen voted on patch set 1 V +1 CR +1 02/06/14, 07:17
-
Peter Beernink commented on patch set 1 V +1 02/06/14, 08:20
Does this change also need to be covered with a unit test?LazyObjectStorage.php:169Shouldn't this be $this->isInitialized === FALSE in order to make it a strict comparison in regards to the new CGL? -
Stefan Neufeind commented on patch set 1 CR +1 02/07/14, 10:20
LazyObjectStorage.php:169Replyimho we still use it like that when it's clearly a boolean -
Marcin Sągol voted on patch set 1 CR +1 02/07/14, 10:35
-
Marc Bastian Heinrichs voted on patch set 1 V +2 CR +2 02/08/14, 10:53
-
Marc Bastian Heinrichs merged patch set 2 02/08/14, 10:53
-
Marc Bastian Heinrichs commented on patch set 2 02/08/14, 10:54
Cherry Picked This patchset was cherry picked to change: I817ce86dde11b175e6a5765a8f6518770ba75f28 -
Marc Bastian Heinrichs commented on patch set 2 02/08/14, 10:54
Cherry Picked This patchset was cherry picked to change: I817ce86dde11b175e6a5765a8f6518770ba75f28