Review main Merged

27357[BUGFIX] Use count on storage after initialization of LazyObjectStorage

Marc Bastian Heinrichs CR +2 V +2 Easy +1 −1 updated 02/08/14, 10:54

Commit message

The count in LazyObjectStorage for relation type HAS_MANY has
to use the count on storage items after initialization. Otherwise
the wrong count is returned for a not persisted storage.

Review

  • Code review CR +2
    • Marc Bastian Heinrichs +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Nico de Haen +1
    • Marcin Sągol +1
  • Verified V +2
    • Marc Bastian Heinrichs +2
    • Nico de Haen +1
    • Peter Beernink +1

Issues 1

Files 1

Review log 11

  1. Marc Bastian Heinrichs wrote 02/05/14, 12:47

    Topic set to "extbase".
  2. Mr. Jenkins commented on patch set 1 02/05/14, 13:14

  3. Wouter Wolters voted on patch set 1 CR +1 02/05/14, 15:57

  4. Nico de Haen voted on patch set 1 V +1 CR +1 02/06/14, 07:17

  5. Peter Beernink commented on patch set 1 V +1 02/06/14, 08:20

    Does this change also need to be covered with a unit test?

    LazyObjectStorage.php:169

    Shouldn't this be $this->isInitialized === FALSE in order to make it a strict comparison in regards to the new CGL?
  6. Stefan Neufeind commented on patch set 1 CR +1 02/07/14, 10:20

    LazyObjectStorage.php:169 Reply

    imho we still use it like that when it's clearly a boolean
  7. Marcin Sągol voted on patch set 1 CR +1 02/07/14, 10:35

  8. Marc Bastian Heinrichs voted on patch set 1 V +2 CR +2 02/08/14, 10:53

  9. Marc Bastian Heinrichs merged patch set 2 02/08/14, 10:53

  10. Marc Bastian Heinrichs commented on patch set 2 02/08/14, 10:54

    Cherry Picked This patchset was cherry picked to change: I817ce86dde11b175e6a5765a8f6518770ba75f28
  11. Marc Bastian Heinrichs commented on patch set 2 02/08/14, 10:54

    Cherry Picked This patchset was cherry picked to change: I817ce86dde11b175e6a5765a8f6518770ba75f28