Review main Merged

27377[BUGFIX] Allow user update without password changes in sys_action

Nicole Hummel CR +2 V +2 Easy +7 −6 updated 03/07/14, 18:44

Commit message

If you want to edit a user within the sys_action module, you have to
set a (new) password as otherwise the record won't be updated. This
patch allows an empty password field for updates while new users
still need a defined password.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 29

Show 4 earlier messages
  1. Marcin Sągol voted on patch set 1 CR +1 02/06/14, 11:05

  2. Markus Klein commented on patch set 1 CR -1 02/06/14, 11:06

    some commit message flaws. will correct them
  3. Markus Klein updated the commit message in patch set 1 02/06/14, 11:06

  4. Markus Klein commented on patch set 2 CR +1 02/06/14, 11:07

    Nice, ticket is already 3 years old. ;-)
  1. Mr. Jenkins commented on patch set 1 02/06/14, 11:17

  2. Michiel Roos voted on patch set 2 CR +1 02/06/14, 11:19

  3. Marcin Sągol voted on patch set 2 CR +1 02/06/14, 11:21

  4. Mr. Jenkins commented on patch set 2 02/06/14, 11:31

  5. Alexander Stehlik voted on patch set 2 V +1 CR +1 02/06/14, 12:52

  6. Tobias Schmidt commented on patch set 2 02/06/14, 17:29

    Patch works in TYPO3 4.5, task/class.tx_sysaction_task.php, line 280 What about line 428 in Classes/ActionTask.php/line 511 in task/class.tx_sysaction_task.php? If someone still uses 'md5' the password would be overwritten if the password field is empty when editing the backend user. Although "md5" is not recommended it should be fixed (look at my patch attached to issue #25700). Or shoulf the check for "md5" completely be removed?
  7. Markus Klein uploaded patch set 3 02/17/14, 13:43

  8. Markus Klein commented on patch set 3 02/17/14, 13:43

    Tobias please re-check
  9. Wouter Wolters commented on patch set 3 CR -1 02/17/14, 13:47

    Please check my inline comment

    ActionTask.php:430

    I did a search for this. Saltedpasswords is enforced now in 6.2 and the TCA is not set to eval md5 anymore. This check is not needed any more. Please correct me if I'm wrong.
  10. Mr. Jenkins commented on patch set 3 02/17/14, 14:04

  11. Tobias Schmidt commented on patch set 3 V +1 CR +1 02/17/14, 14:08

    Looks good. Check for md5 may not be needed in 6.2 but it is needed in 4.5.
  12. Markus Klein commented on patch set 3 02/17/14, 14:50

    Tobias, Patch is not scheduled for 4.5, sorry. You've to get in touch with Ernesto the Release Manager of 4.5 to get an exception for this patch.
  13. Tobias Schmidt commented on patch set 3 V 0 CR 0 02/17/14, 14:55

    Target version of issue #25700 is 4.5.12. My patch file is for 4.5. In my comments I refered to 4.5. Thanks for wasting my time.
  14. Markus Klein commented on patch set 3 02/17/14, 14:57

    Tobias, why being annoyed now? The patch had 6.2 in the releases line since the very beginning. What is the problem of writing a single mail to the RM asking for the exception??
  15. Ernesto Baschny commented on patch set 3 02/28/14, 17:10

    Thanks for asking, guys. Indeed the 4.5 release branch is now in "priority and security fixes only" and this fix unfortunately doesn't qualify. See http://typo3.org/roadmap/ The reasons for having to stick to this policy are: * well, it's a policy :) * even thou you might want to or have put energy into this, a bug fix always involves more people: reviewers, testers and finally merging it (and assuming responsibility). Those resources are scarce, and we need more focus on the stabilization of the current release (6.2). * every bugfix introduces the risk of a regression. Minimizing this risk at this late stage of the release (three years have passed since 4.5.0 BTW) is crucial. * we are now 5 releases later. It's very good to have these kind of bugs fixed some day, and I understand that you want to stay with 4.5 much longer yet. But at least we will have it fixed in our latest stable version. @Tobias, I suggest you to "fix your core" with your patch (so your time was not totally wasted), but let's get the fix into 6.2. After that, you will someday be able to upgrade to 6.2 and use it out of the box without the need to patch. Thanks for understanding!
  16. Ernesto Baschny commented on patch set 3 02/28/14, 17:17

    And btw, the "Target Version" is a field in the issue tracker that is not protected and anybody is able to set it to whatever he likes. This is indeed a big problem, as we cannot plan anything in this regard. We have the policy that only the release managers should set the target versions, and we only have "6.2 LTS" and "next-patchlevel" currently in use. Any other occurrence is no longer supported now. The only reason we still have these choices in the list are because there is tecnically no other way. I set the target 2 years ago to "4.5.12" but noone cared about it. It's not my job to make sure some bug gets fixed (except if it is a prominent or a very important one). Back then noone bothered to fix it, and now it's just too late, as already explained. Therefore I removed the target version.
  17. Tobias Schmidt commented on patch set 3 03/05/14, 10:37

    Thank you for the explanation. I applied the patch to my TYPO3 4.5 installation a few month ago. It is working just fine. I cannot do any testing with TYPO3 6.2 though as I don't have a 6.2 installation available right now and time is short.
  18. Markus Klein commented on patch set 3 03/05/14, 10:46

    ActionTask.php:430 Reply

    Hm... it is not enforced AFAIK, it is installed by default, right? The default TCA for that field is still: 'eval' => 'required,md5,password'
  19. Wouter Wolters commented on patch set 3 03/05/14, 11:00

    ActionTask.php:430 Reply

    Can you uninstall it on current master?
  20. Markus Klein commented on patch set 3 03/05/14, 12:41

    ActionTask.php:430 Reply

    oh I cant. ;-) rsaauth can be. I mixed that up.
  21. Helmut Hummel commented on patch set 3 03/05/14, 19:19

    ActionTask.php:430 Reply

    So creating users here is broken (in terms of password) on master, as this only takes care of md5 hashing, right? Should we fix this in this patch or make another one first?
  22. Wouter Wolters commented on patch set 3 03/05/14, 19:42

    ActionTask.php:430 Reply

    I suggest to make another patch as this is different topic.
  23. Wouter Wolters voted on patch set 3 V +1 CR +1 03/07/14, 18:20

  24. Christian Kuhn voted on patch set 3 V +2 CR +2 03/07/14, 18:44

  25. Christian Kuhn merged patch set 4 03/07/14, 18:44