Review main Merged

27396[TASK] Remove rollover functionality from TMENU

Benni Mack CR +2 V +2 Normal +3 −72 updated 02/07/14, 17:43

Commit message

The TMENU code has "RO" functionality in its class.
This code might be used from TMENU_LAYERS, but
not from the core itself. The core should remove the
according places. If extensions need this functionality
they could implement their own menu functionality.

The patch itself just removes the functionality of
rollovers, which is currently not documented nor used.

The idea of the content object with its extProc classes
is outdated and should be replaced by hooks and/or
signal slots.

As all methods that are removed, are private, they can
IMHO be removed directly.

In a second patch, there will be a hook interface
in order to manipulate the items.

Review

  • Code review CR +2
    • Georg Ringer +2
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 1

Review log 3

  1. Mr. Jenkins commented on patch set 1 02/07/14, 08:26

  2. Georg Ringer voted on patch set 1 V +2 CR +2 02/07/14, 17:43

  3. Georg Ringer merged patch set 2 02/07/14, 17:43