Review main Merged

27412[BUGFIX] Pass path instead of object to fileExistsInFolder

Tymoteusz Motylewski CR +2 V +2 Easy +1 −1 updated 02/07/14, 18:18

Commit message

In ResourceStorage in the method getUniqueName second argument
passed to fileExistsInFolder should be string instead of object.

This fixes an exception thrown when trying to insert magic image
in the RTE.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Michiel Roos +1
    • Marcin Sągol +1
    • Frans Saris +1
  • Verified V +2
    • Steffen Ritter +2
    • Frans Saris +1

Issues 1

Files 1

Review log 7

  1. Tymoteusz Motylewski commented on patch set 1 02/07/14, 13:41

    not sure if this change should also be backported to 6.0 and 6.1
  2. Michiel Roos voted on patch set 1 CR +1 02/07/14, 13:43

  3. Marcin Sągol voted on patch set 1 CR +1 02/07/14, 13:45

  4. Mr. Jenkins commented on patch set 1 02/07/14, 13:54

  5. Frans Saris voted on patch set 1 V +1 CR +1 02/07/14, 16:33

  6. Steffen Ritter voted on patch set 1 V +2 CR +2 02/07/14, 18:18

  7. Steffen Ritter merged patch set 2 02/07/14, 18:18