Review main Merged

27420[TASK] Centralize DB queries

Andreas Wolf CR +2 V +2 Normal +29 −57 updated 02/10/14, 12:44

Commit message

In order to be able to easier debug stuff and intercept database calls,
all queries are made through a central ``query()`` method in
``DatabaseConnection``.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Pascal Dürsteler +1
  • Verified V +2
    • Christian Kuhn +2
    • Pascal Dürsteler +1

Issues 1

Files 1

Review log 11

  1. Mr. Jenkins commented on patch set 1 02/07/14, 16:31

  2. Stefan Neufeind commented on patch set 1 CR +1 02/08/14, 10:07

    Just one nitpick. Besides that I like the idea. I expect the queryies itself are so "expensive" that the additional function-call "won't really matter"?

    DatabaseConnection.php:201

    remove isConnected here as well then
  3. Markus Klein commented on patch set 1 02/08/14, 13:17

    @Stefan: The function call itself is very negligible.

    DatabaseConnection.php:460

    Why the $resultMode parameter if it is not used at all?
  4. Andreas Wolf commented on patch set 1 02/08/14, 14:15

    DatabaseConnection.php:460 Reply

    Could be removed, agreed. I just used an automated refactoring in PhpStorm which always takes all parameters.
  5. Stefan Neufeind uploaded patch set 2 02/09/14, 18:38

  6. Stefan Neufeind commented on patch set 2 CR +1 02/09/14, 18:38

    removed $resultMode and various isConnected
  7. Pascal Dürsteler voted on patch set 2 V +1 CR +1 02/09/14, 18:44

  8. Mr. Jenkins commented on patch set 2 02/09/14, 19:00

  9. Oliver Klee voted on patch set 2 CR +1 02/09/14, 19:22

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 02/10/14, 12:44

  11. Christian Kuhn merged patch set 3 02/10/14, 12:44