Review main Merged

27448[BUGFIX] Wrong colspan in DatabaseRecordList

Marcin Sągol CR +2 V +2 Easy +2 −1 updated 02/08/14, 23:41

Commit message

If the List Module is in extended view, the colspan of the footer
is wrong if there are more than 20 records of a type.

Fix this by increasing the colspan with one if the List Module is
extended view.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 11

  1. Marcin Sągol updated the commit message in patch set 1 02/08/14, 12:07

  2. Mr. Jenkins commented on patch set 1 02/08/14, 12:19

  3. Mr. Jenkins commented on patch set 2 02/08/14, 12:32

  4. Wouter Wolters updated the commit message in patch set 2 02/08/14, 13:11

  5. Wouter Wolters voted on patch set 3 V +1 CR +1 02/08/14, 13:11

  6. Mr. Jenkins commented on patch set 3 02/08/14, 14:38

  7. Christian Kuhn updated the commit message in patch set 3 02/08/14, 17:38

  8. Christian Kuhn commented on patch set 4 V +1 CR +1 02/08/14, 17:45

    Looks good so far, also on testing.
  9. Wouter Wolters voted on patch set 4 V +2 CR +2 02/08/14, 18:19

  10. Wouter Wolters merged patch set 5 02/08/14, 18:19

  11. Mr. Jenkins commented on patch set 4 02/08/14, 23:41