Review main Merged

27450[FEATURE] Column of extension's last update

Zbigniew Jacko CR +2 V +2 Easy +4 −0 updated 12/08/14, 00:27

Commit message

Add column 'Last Updated' in Extension Manager.

Review

  • Code review CR +2
    • Markus Klein +2
    • Mathias Schreiber +1
  • Verified V +2
    • Markus Klein +2
    • Mathias Schreiber +1

Issues 1

Files 2

Review log 40

Show 15 earlier messages
  1. Mr. Jenkins commented on patch set 1 02/08/14, 12:46

  2. Zbigniew Jacko uploaded patch set 2 02/08/14, 13:00

  3. Felix Kopp uploaded patch set 3 02/08/14, 13:11

  4. Tymoteusz Motylewski commented on patch set 3 CR -1 02/08/14, 13:19

    @Felix, why did you upload patch 3? It has wrong whitespaces (spaces instead of tabs). We will push patch 2 again.
  5. Zbigniew Jacko uploaded patch set 4 02/08/14, 13:25

  6. Jost Baron commented on patch set 4 02/08/14, 14:03

    It would be nice if the date format is language dependent, the default format 'Y-m-d' from the f.format.date ViewHelper could be confusing for people not used to it.
  7. Mr. Jenkins commented on patch set 2 02/08/14, 14:08

  8. Mr. Jenkins commented on patch set 3 02/08/14, 14:51

  9. Mr. Jenkins commented on patch set 4 02/08/14, 15:31

  10. Zbigniew Jacko commented on patch set 4 02/08/14, 15:33

    @Jost I can use <f:format.date format="%x">, but I'm not sure if is good solution. Now we have standard date, like in other places in Extension Manager.
  11. Jost Baron commented on patch set 4 02/08/14, 15:58

    @Zbigniew: No, thats not what I meant. It would use the servers locale, which might be different from the date format that should be used in the backend. I'm not really sure about this, but the date format to use in the backend seems to be defined in the $GLOBALS['TYPO3_CONF_VARS']['SYS']['ddmmyy'], according to this issue: http://forge.typo3.org/issues/49400 . But again, I'm not sure about this, so please try to confirm this.
  12. Marcin Sągol commented on patch set 4 02/08/14, 16:11

    Format mentioned by Jost is/will be also by default used by f:format.date viewhelper. See https://review.typo3.org/#/c/27456/
  13. Zbigniew Jacko uploaded patch set 5 02/08/14, 16:22

  14. Zbigniew Jacko commented on patch set 5 02/08/14, 16:25

    @Marcin It seems I need to revert my last patch. So I do it.
  15. Zbigniew Jacko uploaded patch set 6 02/08/14, 16:31

  1. Marcin Sągol voted on patch set 6 V +1 CR +1 02/08/14, 17:01

  2. Felix Kopp commented on patch set 6 02/08/14, 17:12

    Date format must not be fixed here - but in the core. See I patch at https://review.typo3.org/#/c/27456/
  3. Zbigniew Jacko commented on patch set 6 02/08/14, 17:32

    You're right, so here I've just added date without any format
  4. Jost Baron voted on patch set 6 V +1 CR +1 02/08/14, 18:58

  5. Mr. Jenkins commented on patch set 5 02/08/14, 21:52

  6. Mr. Jenkins commented on patch set 6 02/08/14, 22:19

  7. Stefan Neufeind commented on patch set 6 CR +1 02/09/14, 00:10

    "Feature" or maybe "Task"? I've added Ernesto to see what he thinks. Imho it's small enough so we are safe - but we should probably not let is look like we are "adding features".
  8. Mateusz Wojtuła voted on patch set 6 V +1 CR +1 02/09/14, 09:40

  9. Zbigniew Jacko uploaded patch set 7 02/09/14, 13:05

  10. Zbigniew Jacko uploaded patch set 8 02/09/14, 13:13

  11. Zbigniew Jacko commented on patch set 8 02/09/14, 13:14

    Really sorry for patch 7, it was my mistake in git...
  12. Jost Baron voted on patch set 8 V +1 CR +1 02/09/14, 13:16

  13. Marcin Sągol voted on patch set 8 V +1 CR +1 02/09/14, 13:28

  14. Mr. Jenkins commented on patch set 7 02/09/14, 14:31

  15. Mr. Jenkins commented on patch set 8 02/09/14, 14:59

  16. Stefan Neufeind commented on patch set 8 CR +1 02/09/14, 15:45

    Fine with me. But still: Is "[FEATURE]" okay in the current phase? Hmm ...
  17. Felix Kopp commented on patch set 8 02/10/14, 21:29

    Hello everyone. I like the technical implementation and it works. Also we have the f:format.date view helper patch as an outcome. But I think the column is not a perfect fit for the functionality of the extension manager. Displaying the date without the option to filter / sort does not bring a benefit when browsing the TER. Personally I am convinced that the decision for or against an extension is taken in the EM yes - but the process goes differently. Seeing the last update does not make a difference when the filtered extensions are all compatible with the current version of TYPO3 CMS and stable enough. For me personally the date should not be displayed but a filter to exclude extensions older than 1month, 3months, 6months, 1year, …. I think seeing the date does not help since for every extension entry the editor must abstract. Perhaps showing relative dates might improve the information. Also another column raises the risk of breaking table rows. If we include another column most of the information must be rearranged accordingly. What do you think?
  18. Marcin Sągol commented on patch set 8 07/03/14, 09:30

    ping
  19. Mathias Schreiber commented on patch set 8 CR +1 V +1 12/07/14, 17:10

    fine for now. Composer might change things around anyways
  20. Georg Ringer updated the commit message in patch set 9 12/07/14, 17:55

  21. Mathias Schreiber commented on patch set 9 CR +1 V +1 12/07/14, 18:07

    good catch
  22. Markus Klein voted on patch set 9 CR +1 12/07/14, 22:09

  23. Markus Klein voted on patch set 9 CR +2 V +2 12/08/14, 00:27

  24. Markus Klein merged patch set 9 12/08/14, 00:27

  25. Markus Klein commented on patch set 10 12/08/14, 00:27

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 90cb8cc805484a5d57c3fd4d96a27c840c657e13