Review main Merged

27457[TASK] Add mapping between .pps, .ppsx and powerpoint

Mateusz Wojtuła CR +2 V +2 Easy +2 −0 updated 02/08/14, 22:05

Commit message

Add missing mapping between pps, ppsx
and the powerpoint application.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 15

  1. Marcin Sągol commented on patch set 1 02/08/14, 13:55

    mime_types.php

    Indentation before 'pps' => ... is wrong compared to other lines.
  2. Mateusz Wojtuła uploaded patch set 2 02/08/14, 14:20

  3. Marcin Sągol commented on patch set 2 02/08/14, 14:26

    mime_types.php:56

    The ppsx type is valid? Please check http://technet.microsoft.com/en-us/library/ee309278%28office.12%29.aspx or http://filext.com/file-extension/PPSX .ppsx Office PowerPoint 2007 slide show application/vnd.openxmlformats-officedocument.presentationml.slideshow
  4. Zbigniew Jacko voted on patch set 2 V +1 CR +1 02/08/14, 14:27

  5. Christian Kuhn commented on patch set 2 CR -1 02/08/14, 14:31

    mime_types.php:56 Reply

    mmmh, 3rd party libraries should usually not be changed by us. Do we *really* *really* need this and there is no other way?
  6. Mateusz Wojtuła uploaded patch set 3 02/08/14, 14:42

  7. Mateusz Wojtuła commented on patch set 3 02/08/14, 14:44

    As Christian suggested I removed chane in SwiftMailer. This change will be included in new version of SwiftMailer (5.1). See commit: https://github.com/swiftmailer/swiftmailer/commit/c84b343ab750682525386cf99bf646759870a6a2
  8. Mr. Jenkins commented on patch set 1 02/08/14, 16:26

  9. Christian Kuhn updated the commit message in patch set 3 02/08/14, 16:29

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 02/08/14, 16:31

  11. Wouter Wolters voted on patch set 4 V +2 CR +2 02/08/14, 16:33

  12. Wouter Wolters merged patch set 5 02/08/14, 16:33

  13. Mr. Jenkins commented on patch set 2 02/08/14, 19:49

  14. Mr. Jenkins commented on patch set 3 02/08/14, 20:45

  15. Mr. Jenkins commented on patch set 4 02/08/14, 22:05