Review main Merged

27462[BUGFIX] Duplicate exception code

Przemysław Krukowski CR +2 V +2 Normal +69 −69 updated 02/09/14, 14:12

Commit message

Exception codes are unique now.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 47

Show 27 more files

Review log 12

  1. Łukasz Jurys voted on patch set 1 V +1 CR +1 02/08/14, 15:38

  2. Mateusz Wojtuła voted on patch set 1 CR +1 02/08/14, 15:45

  3. Christian Kuhn commented on patch set 1 02/08/14, 16:23

    This fixes only some of the matches if running the script.
  4. Christian Kuhn commented on patch set 1 02/08/14, 16:23

    Package.php:434

    This class is a copy from flow, maybe it could be fixed there, too?
  5. Przemysław Krukowski commented on patch set 1 02/08/14, 16:52

    I have changed only duplicates with different exception classes. I've left those which have the same exception classes and different messages but exist in the same php file. I've also left those which have very similar messages. Should I change all of the ids for exceptions with different messages (even similar and existing in the same file)?
  6. Wouter Wolters commented on patch set 1 02/08/14, 16:56

    All exceptions that are thrown need a unique id, so no duplicates.
  7. Mr. Jenkins commented on patch set 1 02/08/14, 20:58

  8. Przemysław Krukowski uploaded patch set 2 02/09/14, 12:08

  9. Mr. Jenkins commented on patch set 2 02/09/14, 13:44

  10. Christian Kuhn commented on patch set 2 V +1 CR +1 02/09/14, 14:06

    Thank you!
  11. Anja Leichsenring commented on patch set 2 V +2 CR +2 02/09/14, 14:12

    the busy bee of exception codes :D thanks a lot.
  12. Anja Leichsenring merged patch set 3 02/09/14, 14:12