Review main Merged

27463[BUGFIX] Type safe check for $BE_USER in index_ts.php

Łukasz Jurys CR +2 V +2 Easy +7 −1 updated 02/08/14, 22:51

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Marcin Sągol +1
    • Michał Jankiewicz +1
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 10

  1. Michał Jankiewicz commented on patch set 1 CR +1 02/08/14, 16:24

    I couldn't reproduce this bug but looks good.
  2. Christian Kuhn commented on patch set 1 02/08/14, 16:45

    will push another patch set.

    index_ts.php:258

    maybe instanceof ?
  3. Christian Kuhn uploaded patch set 2 02/08/14, 16:59

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 02/08/14, 16:59

  5. Marcin Sągol voted on patch set 2 CR +1 02/08/14, 17:06

  6. Michał Jankiewicz voted on patch set 2 CR +1 02/08/14, 17:22

  7. Wouter Wolters voted on patch set 2 V +2 CR +2 02/08/14, 19:04

  8. Wouter Wolters merged patch set 3 02/08/14, 19:04

  9. Mr. Jenkins commented on patch set 1 02/08/14, 21:12

  10. Mr. Jenkins commented on patch set 2 02/08/14, 22:51