27494[BUGFIX] Fix CSS-path to default .t3-icon image
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Stefan Neufeind +1
- Christian Kuhn +1
Issues 1
Files 1
Review log 11
-
Christian Kuhn commented on patch set 1 02/09/14, 00:50
-
Mr. Jenkins commented on patch set 1 02/09/14, 03:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13868/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13867/ : SUCCESS -
Felix Kopp commented on patch set 1 02/09/14, 10:42
main_content.css:17ReplyNo, icons were always duplicated -
Christian Kuhn commented on patch set 1 02/09/14, 10:57
main_content.css:17ReplyDon't understand, Felix: The patch sets a hard reference to t3skin, so this can not be overwritten? -
Stefan Neufeind commented on patch set 1 02/09/14, 15:43
Yes, I thought about that too for a minute :-) As mentioned on forge candidates are: ./typo3/gfx/icon_fatalerror.gif ./typo3/sysext/t3skin/icons/gfx/icon_fatalerror.gif Deal: Let's change this to the icon under /typo3/gfx, thus avoiding the dep on t3skin. Okay? -
Stefan Neufeind uploaded patch set 2 02/09/14, 18:54
-
Stefan Neufeind commented on patch set 2 V +1 02/09/14, 18:56
no dep on t3skin anymore, using typo3/gfx/ now To verify see some icon like the icon for a page in pagetree in firebug and cross down where t3-icon is defined (is being overwritten by other classes). Check what the original t3-icon would look like and that the path is correct. -
Christian Kuhn voted on patch set 2 V +1 CR +1 02/09/14, 19:10
-
Mr. Jenkins commented on patch set 2 02/09/14, 19:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13911/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13910/ : SUCCESS -
Anja Leichsenring voted on patch set 2 V +2 CR +2 02/09/14, 19:27
-
Anja Leichsenring merged patch set 3 02/09/14, 19:27
main_content.css:17