Review main Merged

27494[BUGFIX] Fix CSS-path to default .t3-icon image

Stefan Neufeind CR +2 V +2 Easy +1 −1 updated 02/09/14, 19:27

Commit message

There is no such icon in
typo3/sysext/backend/Resources/Public/gfx/

Usually the default-icon is overwritten in CSS
anyhow by specifying the icon to use, so the
bug does not show. But the path is still wrong.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Stefan Neufeind +1
    • Christian Kuhn +1

Issues 1

Files 1

Review log 11

  1. Christian Kuhn commented on patch set 1 02/09/14, 00:50

    main_content.css:17

    Hmm, this basically introduces a dependency from ext:backend to ext:t3skin. Is this the case at other places, too, already?
  2. Mr. Jenkins commented on patch set 1 02/09/14, 03:52

  3. Felix Kopp commented on patch set 1 02/09/14, 10:42

    main_content.css:17 Reply

    No, icons were always duplicated
  4. Christian Kuhn commented on patch set 1 02/09/14, 10:57

    main_content.css:17 Reply

    Don't understand, Felix: The patch sets a hard reference to t3skin, so this can not be overwritten?
  5. Stefan Neufeind commented on patch set 1 02/09/14, 15:43

    Yes, I thought about that too for a minute :-) As mentioned on forge candidates are: ./typo3/gfx/icon_fatalerror.gif ./typo3/sysext/t3skin/icons/gfx/icon_fatalerror.gif Deal: Let's change this to the icon under /typo3/gfx, thus avoiding the dep on t3skin. Okay?
  6. Stefan Neufeind uploaded patch set 2 02/09/14, 18:54

  7. Stefan Neufeind commented on patch set 2 V +1 02/09/14, 18:56

    no dep on t3skin anymore, using typo3/gfx/ now To verify see some icon like the icon for a page in pagetree in firebug and cross down where t3-icon is defined (is being overwritten by other classes). Check what the original t3-icon would look like and that the path is correct.
  8. Christian Kuhn voted on patch set 2 V +1 CR +1 02/09/14, 19:10

  9. Mr. Jenkins commented on patch set 2 02/09/14, 19:27

  10. Anja Leichsenring voted on patch set 2 V +2 CR +2 02/09/14, 19:27

  11. Anja Leichsenring merged patch set 3 02/09/14, 19:27