Review main Abandoned

27495[TASK] Replace spacers from clear.gif with spans

Stefan Neufeind CR 0 V 0 Normal +119 −45 updated 09/20/14, 22:09

Commit message

At least in the backend we can replace spacers
currently using a clear.gif with spans like we
already use for t3-icons.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 22

Show 2 more files

Review log 26

Show 1 earlier messages
  1. Stefan Neufeind uploaded patch set 2 02/09/14, 01:51

  1. Stefan Neufeind uploaded patch set 3 02/09/14, 01:54

  2. Stefan Neufeind uploaded patch set 4 02/09/14, 02:04

  3. Stefan Neufeind commented on patch set 4 02/09/14, 02:15

    I expect the spans are more leightweight, semantically more correct imho and we use the same span-technique for t3-icon already. There are some cases where we can't (easily) avoid clear.gif as of today imho: * frontend-related things * input-tags * button-tags Maybe somebody could take a short look at the other clear.gif-places.

    nodeui.js:111

    Unfortunately this and the function below had to be copied from extjs to be overwritten here with spans instead of empty-images. But those are just minor modifications.

    nodeui.js:118

    these two unshifts are replaced

    nodeui.js:163

    this t3-clear is added

    FormsController.php:886

    can't we solve this with padding-left on the following column (the next td here)?

    LogEntries.html:110

    Can't we solve all these with paddings? Would make the table more leightweight/smaller.

    FileList.php:59

    Did I understand hspace correctly here? 1px for the old image itself and then 165px left, 165px right? There are other images with hspace like this in the same patchset here - then check those as well. Can we maybe easily go to just 330px (to have a round number) - same for the the other places.

    ModuleController.php:91

    afaik this is also just backend, so we can use t3skin, right?
  4. Stefan Neufeind commented on patch set 4 02/09/14, 02:19

    Please check the ClickMenu. There is a <span style="width:1px;height:1px" class="t3-clear">&nbsp;</span> as separator for the available options (edit, new, ...). But it's larger than 1px? Hmm why *sigh*
  5. Mr. Jenkins commented on patch set 1 02/09/14, 04:06

  6. Mr. Jenkins commented on patch set 2 02/09/14, 04:19

  7. Mr. Jenkins commented on patch set 3 02/09/14, 04:34

  8. Mr. Jenkins commented on patch set 4 02/09/14, 04:48

  9. Stefan Neufeind commented on patch set 4 02/16/14, 16:25

    ping
  10. Markus Klein commented on patch set 4 CR -1 02/16/14, 17:04

    ClickMenu.php:1180

    Why a $nbsp;?

    FormsController.php:878

    remove the superfluous ()

    FormsController.php:886 Reply

    This is just to ensure the minimum width. Why not min-width on the td itself??

    PagePositionMap.php:175

    height 1 here

    PageLayoutView.php:696

    nope. width 1, height 5

    main_content.css:20

    why relative here?

    LogEntries.html:110 Reply

    Yes I don't get the point why we need these cols here.
  11. Stefan Neufeind commented on patch set 4 02/16/14, 17:47

    @Markus: Thanks for looking that deep into this. Could you maybe do a cleanup of the various cases? Responses to your questions inline.

    ClickMenu.php:1180 Reply

    We have that for icons as well. Afaik some browsers need it since empty spans won't show? Search for spans with t3-icon or so. We might want to look into that separately and if we find a different solution adjust that in other places as well.

    FormsController.php:886 Reply

    Could you maybe give it a try?

    PagePositionMap.php:175 Reply

    yes, slipped through

    PageLayoutView.php:696 Reply

    yes, slipped through

    main_content.css:20 Reply

    taken from t3-clear just some lines below. Didn't want to reinvent the wheel here / didn't question this (in terms of browser-compat etc.).

    LogEntries.html:110 Reply

    just used as spacers
  12. Markus Klein commented on patch set 4 02/17/14, 10:00

    ClickMenu.php:1180 Reply

    Ok fine.

    main_content.css:20 Reply

    ok

    LogEntries.html:110 Reply

    Ok then kill this column and use appropriate CSS. (maybe also remove the valign stuff)

    FileList.php:59 Reply

    Yes hspace is applied left and right. Looks good.
  13. Felix Kopp commented on patch set 4 02/17/14, 10:53

    I personally don't think that this patch goes into the right direction. Spaces should be changed to CSS properties. See http://forge.typo3.org/issues/48540
  14. Stefan Neufeind commented on patch set 4 02/17/14, 11:06

    @Felix: I don't think it will be that easy to do as a "general replacement" like tried here. Imho this change would at least, as a first step, help us get rid of various img-tags. Could you maybe sketch / make an attempt how to do those replacements "the clean way"? I won't find the time shortly to go through each and every place where clear.gif is currently used unfortunately :-(
  15. Felix Kopp commented on patch set 4 02/17/14, 11:12

    Not a blocker from me :) Sure, feel free. I think the time invested might be used to solve the issues once and for all. bgColor2 and height=1px are certainly smells for refactoring.
  16. Felix Kopp commented on patch set 4 02/17/14, 11:13

    (Also consider DocumentTemplate->spacer() as a smell indicator)
  17. Stefan Neufeind commented on patch set 4 02/23/14, 12:11

    Could somebody please have a look / take over?
  18. Stefan Neufeind commented on patch set 4 03/02/14, 07:46

    Somebody interested in taking a closer look maybe? I won't find the time the next days.
  19. Stefan Neufeind commented on patch set 4 04/15/14, 00:31

    Could somebody take a look at this again? @Felix: Can you contribute with the cleanup maybe?
  20. Felix Kopp commented on patch set 4 04/15/14, 08:00

    Hi Stefan, I can work on this issue right now sorry. Also I think it is the wrong approach. All spacers and >spacer should be replaced by padding/margin for the appropiate elements.
  21. Stefan Neufeind abandoned the change 09/20/14, 18:23

    I expect Felix will care care of this during current works on the backend anyway.
  22. Felix Kopp commented on patch set 4 09/20/14, 21:58

    Hey guys - I stand by my opinion that there should be neither span-spacers not span.gif. All padding+margins should be created by padding+margins :) Please deprecate spacer+divider in DocumentTemplate :)
  23. Felix Kopp commented on patch set 4 09/20/14, 22:01

    Everything with height = 1 and a specific width should be border. All spanning image should be min-width or width. And all vertical images should be paddings or margin. Let us see what remains?

    ClickMenu.php:1180 Reply

    Should be a border-bottom. No span here

    Clipboard.php:407

    Should be a border-bottom

    PageLayoutController.php:942

    No idea what this is for :)

    FormsController.php:886 Reply

    Min-Width or width

    AbstractRecordList.php:197

    ? :)
  24. Stefan Neufeind commented on patch set 4 09/20/14, 22:05

    Hey Felix, thanks for taking a look. As written, I abandoned this patchset for now. Feel free to create a new patch matching current rules. (Sorry.)
  25. Felix Kopp commented on patch set 4 09/20/14, 22:09

    W00000t? Let us please telephone tomorrow - do not abandon. We can approve this patch.