27495[TASK] Replace spacers from clear.gif with spans
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 22
- typo3/js/extjs/components/pagetree/javascript/nodeui.js3+61 −1
- typo3/sysext/backend/Classes/ClickMenu/ClickMenu.php4+1 −1
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php1+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/FormsController.php5+1 −1
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php1+1 −1
- typo3/sysext/backend/Classes/RecordList/AbstractRecordList.php1+1 −1
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php2+5 −5
- typo3/sysext/backend/Classes/View/PageLayoutView.php2+5 −5
- typo3/sysext/backend/Resources/Public/Css/visual/main_content.css3+14 −0
- typo3/sysext/belog/Resources/Private/Partials/Content/LogEntries.html4+12 −12
- typo3/sysext/filelist/Classes/FileList.php2+1 −1
- typo3/sysext/indexed_search/Classes/Controller/IndexedPagesController.php+2 −2
- typo3/sysext/indexed_search/Classes/Controller/ModuleController.php1+1 −1
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+2 −2
- typo3/sysext/lowlevel/Classes/View/DatabaseIntegrityView.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php+3 −3
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/User.php+1 −1
- typo3/sysext/t3editor/res/tsref/tsref.xml+1 −1
Review log 26
Show 1 earlier messages
-
Stefan Neufeind uploaded patch set 2 02/09/14, 01:51
-
Stefan Neufeind uploaded patch set 3 02/09/14, 01:54
-
Stefan Neufeind uploaded patch set 4 02/09/14, 02:04
-
Stefan Neufeind commented on patch set 4 02/09/14, 02:15
I expect the spans are more leightweight, semantically more correct imho and we use the same span-technique for t3-icon already. There are some cases where we can't (easily) avoid clear.gif as of today imho: * frontend-related things * input-tags * button-tags Maybe somebody could take a short look at the other clear.gif-places.nodeui.js:111Unfortunately this and the function below had to be copied from extjs to be overwritten here with spans instead of empty-images. But those are just minor modifications.nodeui.js:118these two unshifts are replacednodeui.js:163this t3-clear is addedFormsController.php:886can't we solve this with padding-left on the following column (the next td here)?LogEntries.html:110Can't we solve all these with paddings? Would make the table more leightweight/smaller.FileList.php:59Did I understand hspace correctly here? 1px for the old image itself and then 165px left, 165px right? There are other images with hspace like this in the same patchset here - then check those as well. Can we maybe easily go to just 330px (to have a round number) - same for the the other places.ModuleController.php:91afaik this is also just backend, so we can use t3skin, right? -
Stefan Neufeind commented on patch set 4 02/09/14, 02:19
Please check the ClickMenu. There is a <span style="width:1px;height:1px" class="t3-clear"> </span> as separator for the available options (edit, new, ...). But it's larger than 1px? Hmm why *sigh* -
Mr. Jenkins commented on patch set 1 02/09/14, 04:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13869/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13868/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/09/14, 04:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13870/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13869/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/09/14, 04:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13871/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13870/ : SUCCESS -
Mr. Jenkins commented on patch set 4 02/09/14, 04:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13872/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13871/ : SUCCESS -
Stefan Neufeind commented on patch set 4 02/16/14, 16:25
ping -
Markus Klein commented on patch set 4 CR -1 02/16/14, 17:04
ClickMenu.php:1180Why a $nbsp;?FormsController.php:878remove the superfluous ()FormsController.php:886ReplyThis is just to ensure the minimum width. Why not min-width on the td itself??PagePositionMap.php:175height 1 herePageLayoutView.php:696nope. width 1, height 5main_content.css:20why relative here?LogEntries.html:110ReplyYes I don't get the point why we need these cols here. -
Stefan Neufeind commented on patch set 4 02/16/14, 17:47
@Markus: Thanks for looking that deep into this. Could you maybe do a cleanup of the various cases? Responses to your questions inline.ClickMenu.php:1180ReplyWe have that for icons as well. Afaik some browsers need it since empty spans won't show? Search for spans with t3-icon or so. We might want to look into that separately and if we find a different solution adjust that in other places as well.FormsController.php:886ReplyCould you maybe give it a try?PagePositionMap.php:175Replyyes, slipped throughPageLayoutView.php:696Replyyes, slipped throughmain_content.css:20Replytaken from t3-clear just some lines below. Didn't want to reinvent the wheel here / didn't question this (in terms of browser-compat etc.).LogEntries.html:110Replyjust used as spacers -
Markus Klein commented on patch set 4 02/17/14, 10:00
ClickMenu.php:1180ReplyOk fine.main_content.css:20ReplyokLogEntries.html:110ReplyOk then kill this column and use appropriate CSS. (maybe also remove the valign stuff)FileList.php:59ReplyYes hspace is applied left and right. Looks good. -
Felix Kopp commented on patch set 4 02/17/14, 10:53
I personally don't think that this patch goes into the right direction. Spaces should be changed to CSS properties. See http://forge.typo3.org/issues/48540 -
Stefan Neufeind commented on patch set 4 02/17/14, 11:06
@Felix: I don't think it will be that easy to do as a "general replacement" like tried here. Imho this change would at least, as a first step, help us get rid of various img-tags. Could you maybe sketch / make an attempt how to do those replacements "the clean way"? I won't find the time shortly to go through each and every place where clear.gif is currently used unfortunately :-( -
Felix Kopp commented on patch set 4 02/17/14, 11:12
Not a blocker from me :) Sure, feel free. I think the time invested might be used to solve the issues once and for all. bgColor2 and height=1px are certainly smells for refactoring. -
Felix Kopp commented on patch set 4 02/17/14, 11:13
(Also consider DocumentTemplate->spacer() as a smell indicator) -
Stefan Neufeind commented on patch set 4 02/23/14, 12:11
Could somebody please have a look / take over? -
Stefan Neufeind commented on patch set 4 03/02/14, 07:46
Somebody interested in taking a closer look maybe? I won't find the time the next days. -
Stefan Neufeind commented on patch set 4 04/15/14, 00:31
Could somebody take a look at this again? @Felix: Can you contribute with the cleanup maybe? -
Felix Kopp commented on patch set 4 04/15/14, 08:00
Hi Stefan, I can work on this issue right now sorry. Also I think it is the wrong approach. All spacers and >spacer should be replaced by padding/margin for the appropiate elements. -
Stefan Neufeind abandoned the change 09/20/14, 18:23
I expect Felix will care care of this during current works on the backend anyway. -
Felix Kopp commented on patch set 4 09/20/14, 21:58
Hey guys - I stand by my opinion that there should be neither span-spacers not span.gif. All padding+margins should be created by padding+margins :) Please deprecate spacer+divider in DocumentTemplate :) -
Felix Kopp commented on patch set 4 09/20/14, 22:01
Everything with height = 1 and a specific width should be border. All spanning image should be min-width or width. And all vertical images should be paddings or margin. Let us see what remains?ClickMenu.php:1180ReplyShould be a border-bottom. No span hereClipboard.php:407Should be a border-bottomPageLayoutController.php:942No idea what this is for :)FormsController.php:886ReplyMin-Width or widthAbstractRecordList.php:197? :) -
Stefan Neufeind commented on patch set 4 09/20/14, 22:05
Hey Felix, thanks for taking a look. As written, I abandoned this patchset for now. Feel free to create a new patch matching current rules. (Sorry.) -
Felix Kopp commented on patch set 4 09/20/14, 22:09
W00000t? Let us please telephone tomorrow - do not abandon. We can approve this patch.