Review main Merged

27506[BUGFIX] Strict Standards - setLanguageKeys must be static

Łukasz Jurys CR +2 V +2 Easy +1 −1 updated 02/10/14, 11:48

Commit message

protected LocalizationUtility::setLanguageKeys() is only
called from static initializeLocalization and needs to
be static, too.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 9

  1. Krystian Szymukowicz voted on patch set 1 CR +1 02/09/14, 12:04

  2. Oliver Klee voted on patch set 1 CR +1 02/09/14, 12:24

  3. Mr. Jenkins commented on patch set 1 02/09/14, 12:35

  4. Christian Kuhn uploaded patch set 2 02/10/14, 11:27

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 02/10/14, 11:28

  6. Oliver Klee voted on patch set 2 CR +1 02/10/14, 11:41

  7. Mr. Jenkins commented on patch set 2 02/10/14, 11:43

  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 02/10/14, 11:48

  9. Anja Leichsenring merged patch set 3 02/10/14, 11:48