27510[TASK] Install Tool checks for system locale
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Markus Klein +1
- Tymoteusz Motylewski +1
-
Verified V +2
- Jigal van Hemert +2
- Tymoteusz Motylewski +1
Issues 1
Files 1
Review log 20
-
Zbigniew Jacko uploaded patch set 2 02/09/14, 13:20
-
Marcin Sągol commented on patch set 2 02/09/14, 13:47
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 02/09/14, 14:45
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/13894/ : FAILURE https://ci.typo3.org/job/typo3-v4-core-gerrit/13893/ : FAILURE -
Mr. Jenkins commented on patch set 2 02/09/14, 15:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13898/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13897/ : SUCCESS -
Jigal van Hemert uploaded patch set 3 02/10/14, 21:44
-
Jigal van Hemert uploaded patch set 4 02/10/14, 21:45
-
Jigal van Hemert commented on patch set 4 V +1 CR +1 02/10/14, 21:51
Added support for Windows (different quotes with escapeshellarg(), empty locale uses system settings) and improved combined check for both settings. -
Mr. Jenkins commented on patch set 3 02/10/14, 22:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13953/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13952/ : SUCCESS -
Mr. Jenkins commented on patch set 4 02/10/14, 22:53
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13955/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13954/ : SUCCESS -
Markus Klein commented on patch set 4 02/10/14, 23:27
Great thing, but please see my comments.Check.php:812as not -> as noCheck.php:824Why are we doing this here? I guess it can be stripped completely, because either the setlocale() in the elseif worked out or it didn't, then the old locale is still active.Check.php:844... valid locale is set, which supports UTF-8. This information is included in the phpdoc but not in the message for the user, which is a pity.Check.php:853=== -
Jigal van Hemert commented on patch set 4 02/10/14, 23:43
Check.php:824ReplyThe "system locale" should only be used temporarily while doing something which needs that locale. The original locale should be restored afterwards and that is done by this line. -
Markus Klein commented on patch set 4 02/11/14, 00:22
Check.php:824ReplyOk then it should be moved into the elseif-body. -
Jigal van Hemert uploaded patch set 5 02/12/14, 19:18
-
Jigal van Hemert commented on patch set 5 V +1 CR +1 02/12/14, 19:19
Updated with Markus' remarks. -
Markus Klein voted on patch set 5 CR +1 02/12/14, 19:33
-
Mr. Jenkins commented on patch set 5 02/12/14, 19:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14021/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14020/ : SUCCESS -
Tymoteusz Motylewski voted on patch set 5 V +1 CR +1 02/13/14, 16:29
-
Jigal van Hemert commented on patch set 5 V +2 CR +2 02/14/14, 15:44
Enough votes, merged. -
Jigal van Hemert merged patch set 6 02/14/14, 15:44
-
Christian Kuhn commented on patch set 6 06/29/14, 21:57
post -2. The patch adds access to TYPO3 specific $GLOBALS variables which is NOT allowed in this class. See class comment for details.
Check.php:836