Review main Merged

27518[BUGFIX] Tests: Remove unstable GeneralUtilityTest::getUrl*

Christian Kuhn CR +2 V +2 Easy +0 −0 updated 02/09/14, 20:21

Commit message

Two tests check getUrl() by calling some resource on typo3.org.
This smells funny and the tests are unstable if network, dns
or typo3.org is down or slow. Mocking is not easily possible
with the lowlevel nature of getUrl().
The tests are removed for now.

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 1

Review log 8

  1. Christian Kuhn uploaded patch set 2 02/09/14, 19:07

  2. Christian Kuhn commented on patch set 2 02/09/14, 19:08

    example getUrl test kills travis build for no reason: https://travis-ci.org/TYPO3/TYPO3.CMS/jobs/18524844
  3. Stefan Neufeind updated the commit message in patch set 2 02/09/14, 19:21

  4. Stefan Neufeind voted on patch set 3 V +2 CR +2 02/09/14, 19:22

  5. Stefan Neufeind merged patch set 4 02/09/14, 19:22

  6. Mr. Jenkins commented on patch set 1 02/09/14, 19:54

  7. Mr. Jenkins commented on patch set 2 02/09/14, 20:08

  8. Mr. Jenkins commented on patch set 3 02/09/14, 20:21