Review TYPO3_6-1 Merged

27520[BUGFIX] Tests: Remove unstable GeneralUtilityTest::getUrl*

Stefan Neufeind CR +2 V +2 Easy +0 −0 updated 02/09/14, 19:27

Commit message

Two tests check getUrl() by calling some resource on typo3.org.
This smells funny and the tests are unstable if network, dns
or typo3.org is down or slow. Mocking is not easily possible
with the lowlevel nature of getUrl().
The tests are removed for now.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
  • Verified V +2
    • Stefan Neufeind +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 4

  1. Stefan Neufeind commented on patch set 1 02/09/14, 19:26

    straight from 6.0
  2. Christian Kuhn voted on patch set 1 V +1 CR +1 02/09/14, 19:27

  3. Stefan Neufeind voted on patch set 1 V +2 CR +2 02/09/14, 19:27

  4. Stefan Neufeind merged patch set 2 02/09/14, 19:27