Review main Merged

27539[TASK] Use vfsStream for getFilesInDir() tests

Michiel Roos CR +2 V +2 Easy +0 −0 updated 02/11/14, 22:21

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 17

  1. Mr. Jenkins commented on patch set 1 02/11/14, 10:24

  2. Michiel Roos commented on patch set 1 02/11/14, 10:43

    Should we use \vfsStream::newFile('filename.txt')->withContent('someContent')->at(vfsStreamWrapper::getRoot()); Instead of file_put_contents() ??
  3. Oliver Klee commented on patch set 1 02/11/14, 11:44

    Yes, we should.

    GeneralUtilityTest.php:3313

    I think something like "without vfsStream" would be more helpful in this message. :-)

    GeneralUtilityTest.php:3316

    When the tests are using vfsStream, we don't need any unique filenames anymore.
  4. Oliver Klee commented on patch set 1 02/11/14, 11:47

    GeneralUtilityTest.php:3317

    vfsStream::setUp($directory) would be the same as register + setRoot.

    GeneralUtilityTest.php:3318

    We should use vfsStream::url instead.
  5. Oliver Klee voted on patch set 1 CR -1 02/11/14, 11:47

  6. Oliver Klee commented on patch set 1 02/11/14, 12:19

    +1 for the concept of switching to vfsStream, by the way. This is the way to go.
  7. Michiel Roos uploaded patch set 2 02/11/14, 20:24

  8. Michiel Roos commented on patch set 2 02/11/14, 20:27

    Cleaned up the tests.
  9. Mr. Jenkins commented on patch set 2 02/11/14, 20:39

  10. Michiel Roos uploaded patch set 3 02/11/14, 20:41

  11. Michiel Roos commented on patch set 3 02/11/14, 20:42

    Further cleanup, now creating a whole directory and file structure in the helper method.
  12. Oliver Klee commented on patch set 3 CR +1 02/11/14, 20:54

    Neat!
  13. Christian Kuhn commented on patch set 3 V +1 CR +1 02/11/14, 21:34

    good! thx!
  14. Mr. Jenkins commented on patch set 3 02/11/14, 21:34

  15. Wouter Wolters voted on patch set 3 V +2 CR +2 02/11/14, 22:05

  16. Wouter Wolters merged patch set 4 02/11/14, 22:05

  17. Helmut Hummel commented on patch set 4 02/11/14, 22:21

    @Michiel: Thanks a lot! great we removed the actual writing to the FS in our unit tests!