27539[TASK] Use vfsStream for getFilesInDir() tests
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Issues 1
Files 1
Review log 17
-
Mr. Jenkins commented on patch set 1 02/11/14, 10:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13966/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13965/ : SUCCESS -
Michiel Roos commented on patch set 1 02/11/14, 10:43
Should we use \vfsStream::newFile('filename.txt')->withContent('someContent')->at(vfsStreamWrapper::getRoot()); Instead of file_put_contents() ?? -
Oliver Klee commented on patch set 1 02/11/14, 11:44
Yes, we should.GeneralUtilityTest.php:3313I think something like "without vfsStream" would be more helpful in this message. :-)GeneralUtilityTest.php:3316When the tests are using vfsStream, we don't need any unique filenames anymore. -
Oliver Klee commented on patch set 1 02/11/14, 11:47
GeneralUtilityTest.php:3317vfsStream::setUp($directory) would be the same as register + setRoot.GeneralUtilityTest.php:3318We should use vfsStream::url instead. -
Oliver Klee voted on patch set 1 CR -1 02/11/14, 11:47
-
Oliver Klee commented on patch set 1 02/11/14, 12:19
+1 for the concept of switching to vfsStream, by the way. This is the way to go. -
Michiel Roos uploaded patch set 2 02/11/14, 20:24
-
Michiel Roos commented on patch set 2 02/11/14, 20:27
Cleaned up the tests. -
Mr. Jenkins commented on patch set 2 02/11/14, 20:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13986/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13985/ : SUCCESS -
Michiel Roos uploaded patch set 3 02/11/14, 20:41
-
Michiel Roos commented on patch set 3 02/11/14, 20:42
Further cleanup, now creating a whole directory and file structure in the helper method. -
Oliver Klee commented on patch set 3 CR +1 02/11/14, 20:54
Neat! -
Christian Kuhn commented on patch set 3 V +1 CR +1 02/11/14, 21:34
good! thx! -
Mr. Jenkins commented on patch set 3 02/11/14, 21:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13990/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13989/ : SUCCESS -
Wouter Wolters voted on patch set 3 V +2 CR +2 02/11/14, 22:05
-
Wouter Wolters merged patch set 4 02/11/14, 22:05
-
Helmut Hummel commented on patch set 4 02/11/14, 22:21
@Michiel: Thanks a lot! great we removed the actual writing to the FS in our unit tests!