Review main Merged

27556[BUGFIX] orphan_records show extension manager tables

Tim Lochmüller CR +2 V +2 Easy +2 −0 updated 12/07/14, 21:10

Commit message

Configure the extension manager tables for a valid
orphan_records check in the lowlevel cleaner. Allow
the records on the root level.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Mathias Schreiber +1
  • Verified V +2
    • Helmut Hummel +2
    • Mathias Schreiber +1

Issues 1

Files 2

Review log 16

  1. Mr. Jenkins commented on patch set 1 02/11/14, 19:24

  2. Susi Moog voted on patch set 1 CR +1 02/12/14, 15:10

  3. Markus Klein voted on patch set 1 CR +1 03/13/14, 20:27

  4. Stefan Neufeind uploaded patch set 2 03/13/14, 23:39

  5. Stefan Neufeind commented on patch set 2 03/13/14, 23:40

    just rebased. Had already 2x +1 code-review, no verified yet.
  6. Stefan Neufeind commented on patch set 2 V -1 03/13/14, 23:41

    I wasn't able to verify this. With and without patch result was the same. I ran the test with: ./cli_dispatch.phpsh lowlevel_cleaner orphan_records -s -r
  7. Mr. Jenkins commented on patch set 2 03/13/14, 23:52

  8. Mathias Schreiber commented on patch set 2 CR +1 V +1 12/07/14, 18:42

    Apart from everything else, the extensions tables only make snese on PID 0
  9. Stefan Neufeind commented on patch set 2 12/07/14, 20:11

    @Mathias: Can you explain the difference with and without the patch and how you tested, please?
  10. Mathias Schreiber commented on patch set 2 12/07/14, 20:13

    both tables do not belong anywhere else than onto pid 0. So whenever ANY core component works with these tables, the setting makes sure things are at the right place.
  11. Stefan Neufeind commented on patch set 2 V 0 12/07/14, 20:16

    Removing my -1. I still don't (reproducible) see what was "broken" without the patch. Go ahead ...
    master, 6.2
  12. Helmut Hummel commented on patch set 2 12/07/14, 20:45

    also noticed this with cli lowlevel cleaner recently fix makes sense!
  13. Helmut Hummel voted on patch set 2 CR +2 V +2 12/07/14, 20:45

  14. Helmut Hummel merged patch set 2 12/07/14, 20:46

  15. Helmut Hummel commented on patch set 3 12/07/14, 20:46

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 16d3d9ecf5de4c2a636da41e4515e45a5e85e9d0
  16. Stefan Neufeind commented on patch set 3 12/07/14, 21:10

    Releases-line was not adjusted. But anyway. Thanks for getting this through.