Review main Merged

27557[BUGFIX] Load adminPanel styles for FE editing

Tim Lochmüller CR +2 V +2 Easy +1 −1 updated 03/26/14, 10:15

Commit message

This patch enables frontend editing even if the adminPanel is closed
(minimized). Before adminPanel AND editing tab have to be opened which
isn't really user-friendly.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Stefan Neufeind +1
    • Pascal Dürsteler +1
    • Xavier Perseguers +1
  • Verified V +2
    • Nicole Hummel +2
    • Stefan Neufeind +1
    • Pascal Dürsteler +1

Issues 1

Files 1

Review log 17

  1. Mr. Jenkins commented on patch set 1 02/11/14, 20:01

  2. Tymoteusz Motylewski commented on patch set 1 02/21/14, 16:10

    how can I test that? what is your TS and TypoScript config regarding admin panel and fe_editing?
  3. Tim Lochmüller commented on patch set 1 02/22/14, 16:36

    Hey, disable the admPanel in FE TS (default) and enable the FE editing via UserTsConfig. e.g. admPanel { enable.edit = 1 override.edit { displayIcons = 1 displayFieldIcons = 1 } }
  4. Stefan Neufeind commented on patch set 1 03/09/14, 18:49

    hmm, didn't manage to get the icons to show for some reason
  5. Nicole Hummel uploaded patch set 2 03/21/14, 23:51

  6. Mr. Jenkins commented on patch set 2 03/22/14, 00:04

  7. Nicole Hummel uploaded patch set 3 03/22/14, 00:54

  8. Nicole Hummel updated the commit message in patch set 3 03/22/14, 01:03

  9. Nicole Hummel updated the commit message in patch set 4 03/22/14, 01:03

  10. Stefan Neufeind voted on patch set 5 V +1 CR +1 03/22/14, 01:05

  11. Mr. Jenkins commented on patch set 3 03/22/14, 01:08

  12. Mr. Jenkins commented on patch set 4 CR -1 V -1 03/22/14, 01:22

  13. Mr. Jenkins commented on patch set 5 03/22/14, 01:22

  14. Pascal Dürsteler voted on patch set 5 V +1 CR +1 03/24/14, 15:29

  15. Xavier Perseguers voted on patch set 5 CR +1 03/26/14, 10:02

  16. Nicole Hummel voted on patch set 5 V +2 CR +2 03/26/14, 10:15

  17. Nicole Hummel merged patch set 6 03/26/14, 10:15