27559[TASK] Cleanup ArrayUtility::sortArraysByKey()
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Issues 1
Files 1
Review log 13
-
Oliver Klee commented on patch set 1 02/11/14, 21:13
ArrayUtility.php:287$a and $b could have type hinting here.ArrayUtility.php:294Or shorter (and more clean IMHO): return $ascending ? strcasecmp(...) : strcasecmp(...); -
Michiel Roos commented on patch set 1 02/11/14, 21:21
ArrayUtility.php:285Replyempty() then, without the ! -
Michiel Roos uploaded patch set 2 02/11/14, 21:24
-
Oliver Klee commented on patch set 1 02/11/14, 21:28
ArrayUtility.php:285ReplyRight, of course! ;-) -
Oliver Klee commented on patch set 2 CR +1 02/11/14, 21:29
ArrayUtility.php:279bool -
Michiel Roos uploaded patch set 3 02/11/14, 21:38
-
Oliver Klee commented on patch set 3 CR +1 02/11/14, 21:41
Nice cleanup! -
Christian Kuhn voted on patch set 3 V +1 CR +1 02/11/14, 21:47
-
Mr. Jenkins commented on patch set 1 02/11/14, 21:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13991/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13990/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/11/14, 22:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13992/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13991/ : SUCCESS -
Wouter Wolters voted on patch set 3 V +2 CR +2 02/11/14, 22:02
-
Wouter Wolters merged patch set 4 02/11/14, 22:02
-
Mr. Jenkins commented on patch set 3 02/11/14, 22:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13993/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13992/ : SUCCESS
ArrayUtility.php:285