Review main Merged

27583[BUGFIX] No duplicate insertion in addToAllTCAtypes

Alexander Stehlik CR +2 V +2 Normal +41 −41 updated 02/18/14, 21:33

Commit message

This patch improves the regular expression in
ExtensionManagementUtility::executePositionedStringInsertion().

It is made sure that the field name ends with a comma or a line
ending to prevent duplicate insertions of the string when field
names start with the same substring.

Review

  • Code review CR +2
    • Markus Klein +2
    • Michiel Roos +1
  • Verified V +2
    • Markus Klein +2
    • Michiel Roos +1

Issues 1

Files 2

Review log 6

  1. Mr. Jenkins commented on patch set 1 02/12/14, 16:03

  2. Markus Klein commented on patch set 1 CR +1 02/12/14, 19:29

    Thanks. This is an important fix!
  3. Markus Klein voted on patch set 1 V +1 02/17/14, 13:16

  4. Michiel Roos voted on patch set 1 V +1 CR +1 02/18/14, 21:29

  5. Markus Klein voted on patch set 1 V +2 CR +2 02/18/14, 21:33

  6. Markus Klein merged patch set 2 02/18/14, 21:33