27586[!!!][BUGFIX] Content Object instances are reused
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Stefan Neufeind +1
- Markus Klein +1
-
Verified V +2
- Helmut Hummel +2
- Stefan Neufeind +1
- Markus Klein +1
Issues 1
Files 2
Review log 26
Show 1 earlier messages
-
Mr. Jenkins commented on patch set 1 02/12/14, 17:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14015/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14014/ : SUCCESS
-
Markus Klein commented on patch set 1 02/12/14, 17:20
ContentObjectRenderer.php:782isset check missing. -
Helmut Hummel voted on patch set 1 CR +1 02/12/14, 19:03
-
Oliver Hader commented on patch set 1 02/13/14, 09:30
ContentObjectRenderer.php:782ReplyWas not there before, but you're right... I'll add it -
Oliver Hader uploaded patch set 2 02/13/14, 09:42
-
Mr. Jenkins commented on patch set 2 02/13/14, 10:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14029/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14028/ : SUCCESS -
Oliver Hader uploaded patch set 3 02/13/14, 10:43
-
Mr. Jenkins commented on patch set 3 02/13/14, 11:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14033/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14032/ : SUCCESS -
Markus Klein voted on patch set 3 CR +1 02/13/14, 12:09
-
Oliver Hader uploaded patch set 4 02/14/14, 16:36
-
Markus Klein voted on patch set 4 CR +1 02/14/14, 17:01
-
Mr. Jenkins commented on patch set 4 02/14/14, 17:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14060/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14059/ : SUCCESS -
Helmut Hummel commented on patch set 4 V -1 CR +1 02/14/14, 17:33
Unit tests need adaption! -
Helmut Hummel commented on patch set 4 02/14/14, 17:34
or better: removal of according tests... -
Helmut Hummel uploaded patch set 5 02/14/14, 17:37
-
Helmut Hummel voted on patch set 5 V +1 CR +2 02/14/14, 17:37
-
Mr. Jenkins commented on patch set 5 02/14/14, 18:10
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14063/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14062/ : SUCCESS -
Christian Kuhn commented on patch set 5 CR +1 02/14/14, 18:30
oh yeah :) -
Helmut Hummel commented on patch set 5 02/14/14, 20:07
ContentObjectRenderer.php:785Maybe we can even skip the class_exists here as we can be pretty sure that the class exists because the mapping is quite fixed. before there was no isset and therefore the class_exists was needed to avoid a fatal -
Stefan Neufeind voted on patch set 5 CR +1 02/16/14, 16:59
-
Markus Klein uploaded patch set 6 02/17/14, 12:49
-
Markus Klein commented on patch set 6 V +1 CR +1 02/17/14, 12:50
Removed the class_exists(). No way this could fail without having a corrupted Core. -
Mr. Jenkins commented on patch set 6 02/17/14, 13:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14104/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14103/ : SUCCESS -
Stefan Neufeind commented on patch set 6 V +1 CR +1 02/17/14, 14:06
Fine by reading and tests still run fine. -
Helmut Hummel commented on patch set 6 V +2 CR +2 02/17/14, 14:58
Thanks for the updates and the reviews! -
Helmut Hummel merged patch set 7 02/17/14, 14:58