2761[FEATURE] Use update-query to write fe_session data
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Georg Ringer +1
- Jo Hasenau +1
- Markus Klein +1
- Xavier Perseguers +1
- Helmut Hummel +1
- Mario Rimann +1
-
Verified V +2
- Christian Kuhn +2
- Helmut Hummel +1
Issues 1
Files 1
Review log 43
Show 18 earlier messages
-
Mario Rimann commented on patch set 1 07/31/11, 11:59
I would prefer that you didn't submit this Only CGL nitpickingclass.tslib_feuserauth.php:381CGL: Please remove space before (class.tslib_feuserauth.php:409CGL: Please remove space before ( -
Björn Pedersen commented on patch set 1 07/31/11, 11:59
Looks good to me, but someone else must approve -
Andreas Wolf commented on patch set 2 07/31/11, 11:59
Looks good to me, but someone else must approve -
Mario Rimann commented on patch set 2 07/31/11, 11:59
Looks good to me, but someone else must approve -
Stefan Neufeind uploaded patch set 2 07/31/11, 11:59
-
Stefan Neufeind commented on patch set 2 07/31/11, 11:59
(1 inline comment) -
Stefan Neufeind commented on patch set 2 07/31/11, 11:59
CGL-update. Sorry, didn't spot those two spaces. -
Stefan Neufeind uploaded patch set 3 07/31/11, 11:59
-
Stefan Neufeind commented on patch set 3 07/31/11, 11:59
Took care of Philipp's comment regard the commit-message. Thanks a lot, you were right of course. Rest of reviews looked good. Maybe somebody could go for a "verified" and get it through? -
Stefan Neufeind commented on patch set 3 07/31/11, 11:59
(1 inline comment) -
Stefan Neufeind commented on patch set 4 07/31/11, 11:59
Could somebody please have a final look/try at this? -
Stefan Neufeind uploaded patch set 4 07/31/11, 11:59
-
Markus Klein commented on patch set 3 1 comment 07/31/11, 11:59
I would prefer that you didn't submit this -
Markus Klein commented on patch set 4 07/31/11, 11:59
(2 inline comments) -
Markus Klein commented on patch set 4 07/31/11, 11:59
Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 4 07/31/11, 11:59
Looks good to me, but someone else must approve -
Helmut Hummel commented on patch set 4 07/31/11, 11:59
(1 inline comment) I'm not generally against this change, but wanted to be sure that anybody who voted +1 is aware of the fact, that this change will result in an extra database query even on sites that do not make use of fe_sessions at all. This might be a problem on high traffic sites with many new users hitting it, because for every new user a fe_session record is stored into the database. When we fixed the session fixation problem back then, we agreed to avoid an additional query during the frontend rendering. Nevertheless the "side-effect" of this change would be that the session cookie for fe_users would stay the same, as there would be a session record stored in the db for every user (repeating myself) -
Helmut Hummel commented on patch set 5 07/31/11, 11:59
Fails; Do not submit OOps, this does not work. I will investigate
-
Helmut Hummel uploaded patch set 5 07/31/11, 11:59
-
Mario Rimann commented on patch set 6 07/31/11, 11:59
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 6 07/31/11, 11:59
Just to make sure: Is there a way to only send insert/update when FE-sessions are used? Is there already an issue tracking that or should we open one? -
Markus Klein commented on patch set 6 07/31/11, 11:59
Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 6 07/31/11, 11:59
Looks good to me, but someone else must approve -
Helmut Hummel uploaded patch set 6 07/31/11, 11:59
-
Helmut Hummel commented on patch set 6 07/31/11, 11:59
Nobody willing to test this? ;) -
Helmut Hummel commented on patch set 6 07/31/11, 11:59
Verified; Looks good to me, but someone else must approve OK, now I fixed the last changeset, by setting the sessionDataTimestamp in any place where the session data is fetched -
Helmut Hummel commented on patch set 6 07/31/11, 11:59
@Stefan: This is actually the case with patch set 6. If no session data was found, and/ or session data is not changed, no insert/update query is done. -
Christian Kuhn commented on patch set 6 V 0 07/31/11, 11:59
by team member; Looks good to me, approved -
Georg Ringer commented on patch set 2 07/31/11, 11:59
Verified; Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 6 1 comment 07/31/11, 11:59
Looks good to me, but someone else must approve -
Steffen Gebert commented on patch set 4 07/31/11, 11:59
Looks good to me, but someone else must approve Umm.. looks valid. This changes the behavior of fetchSessionData() a bit, as it now creates the session, if it does not exist. I'd like to have some other's opinion here, too. But I think we can go for it. -
Steffen Ritter commented on patch set 4 07/31/11, 11:59
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 07/31/11, 11:59
I would prefer that you didn't submit this Please mind the comment. As the first line will go into changelog, this should strictly follow the standard.Please remove the "+" before feature. -
Philipp Gampe commented on patch set 4 07/31/11, 11:59
Verified; Looks good to me, but someone else must approve -
Jo Hasenau commented on patch set 4 07/31/11, 11:59
Looks good to me, but someone else must approve -
Jo Hasenau commented on patch set 6 07/31/11, 11:59
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 07/31/11, 11:59
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/735/ : SUCCESS -
Mr. Jenkins commented on patch set 2 07/31/11, 11:59
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/736/ : SUCCESS -
Mr. Jenkins commented on patch set 3 07/31/11, 11:59
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/745/ : SUCCESS -
Mr. Jenkins commented on patch set 4 07/31/11, 11:59
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/746/ : SUCCESS -
Mr. Jenkins commented on patch set 5 07/31/11, 11:59
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1323/ : SUCCESS -
Mr. Jenkins commented on patch set 6 07/31/11, 11:59
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1327/ : SUCCESS -
Christian Kuhn merged patch set 6 07/31/11, 11:59