Review main Merged

27633[BUGFIX] rdndt getClassSchema() in thawProperties(

Michiel Roos CR +2 V +2 Easy +2 −1 updated 02/14/14, 19:53

Commit message

getClassSchema() is being called within a foreach loop while the
$className never changes for that call.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Marcin Sągol +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 5

  1. Marcin Sągol voted on patch set 1 CR +1 02/14/14, 16:43

  2. Mr. Jenkins commented on patch set 1 02/14/14, 17:43

  3. Wouter Wolters commented on patch set 1 V +1 CR +1 02/14/14, 18:42

    Had a good look at the code and ran the unit-tests.
  4. Helmut Hummel voted on patch set 1 V +2 CR +2 02/14/14, 19:53

  5. Helmut Hummel merged patch set 2 02/14/14, 19:53