27641[BUGFIX] Usage of undefined variables in ShortcutToolbarItem
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Markus Klein +1
- Stefano Kowalke +1
-
Verified V +2
- Stefan Neufeind +2
- Markus Klein +1
Issues 1
Files 3
Review log 10
-
Mr. Jenkins commented on patch set 1 02/16/14, 12:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14077/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14076/ : SUCCESS -
Stefano Kowalke commented on patch set 1 02/16/14, 12:32
ShortcutToolbarItem.php:226If you init $lastGroup with NULL, to me it looks like you can remove the variable $lastGroup from if condition at line 272: $lastGroup = NULL; --> (string)$lastGroup is the same like '' (an empty String) --> if ($shortcutGroup && (string)$shortcutGroup !== '' && $shortcutGroup != -100) -
Markus Klein uploaded patch set 2 02/16/14, 13:38
-
Markus Klein commented on patch set 2 CR +1 02/16/14, 13:41
ShortcutToolbarItem.php:302sc_group is defined as tinyint in DB. So we can safely work on integers here.ShortcutToolbarItem.php:331Completely unused in whole core. -
Mr. Jenkins commented on patch set 2 02/16/14, 14:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14078/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14077/ : SUCCESS -
Stefan Neufeind voted on patch set 2 CR +1 02/16/14, 16:32
-
Stefano Kowalke voted on patch set 2 CR +1 02/17/14, 08:32
-
Markus Klein voted on patch set 2 V +1 02/17/14, 12:38
-
Stefan Neufeind voted on patch set 2 V +2 CR +2 02/17/14, 14:09
-
Stefan Neufeind merged patch set 3 02/17/14, 14:09