Review main Merged

27641[BUGFIX] Usage of undefined variables in ShortcutToolbarItem

Tim Lochmüller CR +2 V +2 Normal +62 −34 updated 02/17/14, 14:09

Commit message

Fix a undefined variable and a wrong variable assignment in the
ShortcurtToolbarItem.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • Stefano Kowalke +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 1

Files 3

Review log 10

  1. Mr. Jenkins commented on patch set 1 02/16/14, 12:25

  2. Stefano Kowalke commented on patch set 1 02/16/14, 12:32

    ShortcutToolbarItem.php:226

    If you init $lastGroup with NULL, to me it looks like you can remove the variable $lastGroup from if condition at line 272: $lastGroup = NULL; --> (string)$lastGroup is the same like '' (an empty String) --> if ($shortcutGroup && (string)$shortcutGroup !== '' && $shortcutGroup != -100)
  3. Markus Klein uploaded patch set 2 02/16/14, 13:38

  4. Markus Klein commented on patch set 2 CR +1 02/16/14, 13:41

    ShortcutToolbarItem.php:302

    sc_group is defined as tinyint in DB. So we can safely work on integers here.

    ShortcutToolbarItem.php:331

    Completely unused in whole core.
  5. Mr. Jenkins commented on patch set 2 02/16/14, 14:08

  6. Stefan Neufeind voted on patch set 2 CR +1 02/16/14, 16:32

  7. Stefano Kowalke voted on patch set 2 CR +1 02/17/14, 08:32

  8. Markus Klein voted on patch set 2 V +1 02/17/14, 12:38

  9. Stefan Neufeind voted on patch set 2 V +2 CR +2 02/17/14, 14:09

  10. Stefan Neufeind merged patch set 3 02/17/14, 14:09