Review TYPO3_6-1 Merged

27676[BUGFIX] Invalid shortcut target on translated pages

Stefan Neufeind CR +2 V +2 Easy +41 −2 updated 09/20/14, 17:55

Commit message

A feature to resolve shortcut links directly in menu rendering
does not consider the overlay behaviour of the "shortcut" value.

TSFE first uses the "shortcut" value of the original/default
page and then serves for possible translated alternatives
(TypoScriptFrontendController::checkTranslatedShortcut()).
In menu rendering it's the other way round, the translated
overlay (if any) is used directly - the fallback to use the
"shortcut" value of the original/default page is not implemented.

This change introduces the fallback when rendering menus, which
will take the "shortcut" value of the default language if the
value in the overlay is empty.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Oliver Hader +2
  • Verified V +2
    • Stefan Neufeind +2

Files 1

Review log 4

  1. Stefan Neufeind commented on patch set 1 02/17/14, 22:57

    straight
  2. Oliver Hader commented on patch set 1 CR +2 03/12/14, 14:30

    Looks good, please test again and then go ahead with merging...
  3. Stefan Neufeind voted on patch set 1 CR +2 V +2 09/20/14, 17:55

  4. Stefan Neufeind merged patch set 1 09/20/14, 17:55