Review main Merged

27702[BUGFIX] Title field disappears after using addToAllTCAtypes()

Michiel Roos CR +2 V +2 Easy +45 −2 updated 02/28/14, 19:08

Commit message

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Helmut Hummel +2
    • Markus Klein +1
    • Wouter Wolters +1

Issues 1

Files 2

Review log 30

Show 5 earlier messages
  1. Wouter Wolters voted on patch set 1 CR +1 02/18/14, 21:41

  2. Markus Klein commented on patch set 1 CR -1 02/18/14, 22:59

    ExtensionManagementUtility.php:563

    Nope. The correct is: ", \t\n\r\0\x0B"
  3. Wouter Wolters commented on patch set 1 CR 0 02/18/14, 23:02

    Agreeing with Markus here
  4. Michiel Roos uploaded patch set 2 02/18/14, 23:15

  5. Wouter Wolters voted on patch set 2 CR +1 02/18/14, 23:20

  1. Mr. Jenkins commented on patch set 1 02/19/14, 01:46

  2. Mr. Jenkins commented on patch set 2 02/19/14, 02:15

  3. Markus Klein voted on patch set 2 CR +1 02/19/14, 13:03

  4. Philipp Wrann commented on patch set 1 02/26/14, 12:17

    Patch Set 2: Code-Review+1
  5. Tymoteusz Motylewski commented on patch set 2 02/26/14, 13:51

    would be super to have also test for that :)
  6. Alexander Stehlik voted on patch set 2 V +1 CR +1 02/26/14, 13:54

  7. Michiel Roos voted on patch set 2 V +1 CR +1 02/26/14, 14:44

  8. Helmut Hummel commented on patch set 2 CR -1 02/26/14, 14:57

    Thanks for the fix. It would be great, if you could add a test that fails without and passes with the fix. That would also help to easily verify this change. Thanks a lot!
  9. Alexander Stehlik uploaded patch set 3 02/26/14, 16:57

  10. Alexander Stehlik commented on patch set 3 02/26/14, 16:57

    Added unit test
  11. Alexander Stehlik voted on patch set 3 V +1 CR +1 02/26/14, 16:58

  12. Mr. Jenkins commented on patch set 3 02/26/14, 17:10

  13. Michiel Roos commented on patch set 3 02/26/14, 18:47

    ExtensionManagementUtility.php:574

    We need one more space after the comma here.
  14. Michiel Roos commented on patch set 3 02/26/14, 18:53

    Alexander, does the test fail for you with the single quoted version? I can't get it to fail. If it fails for you, I can +1
  15. Markus Klein commented on patch set 3 02/26/14, 20:56

    ExtensionManagementUtility.php:574 Reply

    Why?

    ExtensionManagementUtilityTest.php:564

    php doc missing
  16. Michiel Roos commented on patch set 3 02/26/14, 21:05

    ExtensionManagementUtility.php:574 Reply

    To make the list nice like: newA, newB, newC, addedA, addedB Instead of: newA, newB, newC,addedA, addedB
  17. Michiel Roos commented on patch set 3 02/26/14, 21:06

    The unit tests don't check for this I think. Only for adding before, after and replace.
  18. Alexander Stehlik commented on patch set 3 02/26/14, 22:26

    Michiel: the first input from the data provider fails for me with the old version: Expected: tr0 Actual: <empty string>
  19. Markus Klein commented on patch set 3 02/26/14, 23:20

    ExtensionManagementUtility.php:574 Reply

    my mistake thanks. we're adding the space everywhere. so do it here too.
  20. Markus Klein uploaded patch set 4 02/26/14, 23:24

  21. Markus Klein commented on patch set 4 V +1 CR +1 02/26/14, 23:25

    Tests are fine. Fail without the change and succeed with the change. The only weird thing is, that we're writing a test for the trim() function, since the bug itself was not a bug, but simply missing knowledge about PHP strings. :-P
  22. Mr. Jenkins commented on patch set 4 02/26/14, 23:36

  23. Wouter Wolters voted on patch set 4 V +1 CR +1 02/28/14, 18:45

  24. Helmut Hummel commented on patch set 4 V +2 CR +2 02/28/14, 19:08

    Thank you guys!
  25. Helmut Hummel merged patch set 5 02/28/14, 19:08