Review main Merged

27746[FEATURE] Add signal slots to SoftReferenceIndex

Alexander Stehlik CR +2 V +2 Normal +86 −61 updated 07/06/14, 22:09

Commit message

This patch adds two signal slot dispatch calls to the SoftReferenceIndex
in the getTypoLinkParts() method and the setTypoLinkPartsElement()
methods.

These slots allow third party link handlers to generate their own
soft reference data.

Review

  • Code review CR +2
    • Markus Klein +2
    • Lorenz Ulrich +1
    • Marcin Sągol +1
  • Verified V +2
    • Markus Klein +2
    • Lorenz Ulrich +1

Issues 1

Files 1

Review log 15

  1. Mr. Jenkins commented on patch set 1 02/20/14, 00:26

  2. Alexander Stehlik uploaded patch set 2 03/10/14, 09:43

  3. Alexander Stehlik commented on patch set 2 03/10/14, 09:43

    Rebased
  4. Mr. Jenkins commented on patch set 2 03/10/14, 09:57

  5. Lorenz Ulrich voted on patch set 2 V +1 CR +1 06/20/14, 20:45

  6. Lorenz Ulrich updated the commit message in patch set 2 06/20/14, 20:45

  7. Lorenz Ulrich voted on patch set 3 V +1 CR +1 06/20/14, 20:46

  8. Markus Klein commented on patch set 3 06/20/14, 20:49

    @ernesto: approval for 6.2 needed
  9. Mr. Jenkins commented on patch set 3 06/20/14, 21:18

  10. Markus Klein voted on patch set 3 CR +1 06/29/14, 15:57

  11. Markus Klein commented on patch set 3 07/02/14, 20:43

    @ernesto: approval please.
  12. Marcin Sągol voted on patch set 3 CR +1 07/03/14, 08:51

  13. Markus Klein commented on patch set 3 V +2 CR +2 07/06/14, 22:09

    No response since weeks, I'm merging this now.
  14. Markus Klein merged patch set 4 07/06/14, 22:09

  15. Markus Klein commented on patch set 4 07/06/14, 22:09

    Cherry Picked This patchset was cherry picked to change: If2bbcd1757ed480f31c1bdccd69bba2a77df9a8f