Review main Merged

27772[BUGFIX] Remove wrong storage->isPublic() check in localFolderTree

Frans Saris CR +2 V +2 Easy +1 −1 updated 03/11/14, 17:52

Commit message

In localFolderTree->ext_isLinkable() is a check for storage->isPublic()
but the isPublic flag has nothing to do with the fact if links
to the files can be created.

This change removes this check.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Wouter Wolters +1
    • Sebastian Fischer +1
  • Verified V +2
    • Steffen Ritter +2

Issues 1

Files 1

Review log 11

  1. Frans Saris uploaded patch set 2 02/21/14, 12:50

  2. Steffen Ritter commented on patch set 2 02/21/14, 12:57

    for folders that's actually correct - older cannot jumpurld. you could getPublicUrl === NULL
  3. Frans Saris commented on patch set 2 02/21/14, 13:15

    It is not to link the folder itself. But this disables the folder in the element browser filetree. So you can not click on it to select a file in such a storage/folder. Easy to spot: in RTE click on insert link and then go to the file tab.
  4. Mr. Jenkins commented on patch set 1 02/21/14, 13:20

  5. Mr. Jenkins commented on patch set 2 02/21/14, 13:33

  6. Wouter Wolters wrote 03/06/14, 22:56

    Topic set to "fal".
  7. Wouter Wolters voted on patch set 2 CR +1 03/06/14, 22:56

  8. Sebastian Fischer voted on patch set 2 CR +1 03/11/14, 17:29

  9. Steffen Ritter voted on patch set 2 CR +2 03/11/14, 17:30

  10. Steffen Ritter voted on patch set 2 V +2 03/11/14, 17:52

  11. Steffen Ritter merged patch set 3 03/11/14, 17:52