27787[BUGFIX] Cannot use contain with multivalued static enumeration column
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Alexander Opitz +1
- Wouter Wolters +1
- Stefan Froemken +1
-
Verified V +2
- Markus Klein +2
- Stefan Froemken +1
Files 1
Review log 16
-
Mr. Jenkins commented on patch set 1 02/22/14, 01:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14237/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14236/ : SUCCESS -
Markus Klein voted on patch set 1 CR +1 02/22/14, 10:07
-
Tomas Norre Mikkelsen voted on patch set 1 CR +1 02/28/14, 21:57
-
Marc Bastian Heinrichs wrote 03/01/14, 09:28
Topic set to "extbase". -
Marc Bastian Heinrichs commented on patch set 1 CR -1 03/01/14, 09:42
Typo3DbBackend.php:626Quering a relation based on the type RELATION_NONE sounds not reasonable to me. Also I suspect that this would enable querying with contains on properties where this have not to be used and should not work. Also the principle of DRY is ignored here. I suggest to detect this type of relation as RELATION_HAS_MANY correct in the Datamapper. -
Xavier Perseguers uploaded patch set 2 03/01/14, 10:17
-
Mr. Jenkins commented on patch set 2 03/01/14, 10:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14468/ : SUCCESS -
Markus Klein updated the commit message in patch set 2 03/02/14, 18:13
-
Markus Klein commented on patch set 3 CR +1 03/02/14, 18:14
Just fixed the last paragraph of the commit message -
Mr. Jenkins commented on patch set 3 03/02/14, 18:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14494/ : SUCCESS -
Alexander Opitz voted on patch set 3 CR +1 03/03/14, 14:08
-
Wouter Wolters voted on patch set 3 CR +1 03/03/14, 18:58
-
Stefan Froemken commented on patch set 3 V +1 CR +1 03/04/14, 08:58
Tested with an extension i have programmed for this ticket. Works like expected. -
Markus Klein voted on patch set 3 V +2 CR +2 03/04/14, 16:11
-
Markus Klein merged patch set 4 03/04/14, 16:11
-
Marc Bastian Heinrichs commented on patch set 4 03/04/14, 17:16
I suspect that this could cause a regression, when using such field in the order or on a childelement contains('somechild.somecolumn', $value), because Typo3DbBackend will add a join to the child table which is not there and will quite with a exception. Could somebody this check, please. thx