Review main Merged

27814[FEATURE] Allow multiple HTTP headers of the same type in TS

Marco Huber CR +2 V +2 Easy +48 −0 updated 01/04/15, 16:18

Commit message

Allows multiple HTTP headers of the same type in
config.additionalHeaders by extending the configuration
possibilities:

mypage.config.additionalHeaders {
	10 {
		#the header string
		header = WWW-Authenticate: Negotiate

		#replace previous headers with the same name
                #optional, default is 1 (yes)
                replace = 0

                #force the HTTP response code
		#optional
                httpResponseCode = 401
	}
}

See also: http://php.net/header

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Mathias Schreiber +1
    • Benni Mack +1
  • Verified V +2
    • Anja Leichsenring +2
    • Mathias Schreiber +1
    • Benni Mack +1

Issues 1

Files 2

Review log 20

  1. Marco Huber uploaded patch set 2 02/24/14, 13:15

  2. Marco Huber commented on patch set 2 02/24/14, 13:17

    Patch set 2 fixes a typo in the commit message. I know, the commit message's first line is still too long, but I can't find a shorter title ;-)
  3. Mr. Jenkins commented on patch set 1 CR -1 V -1 02/24/14, 13:26

  4. Mr. Jenkins commented on patch set 2 CR -1 V -1 02/24/14, 13:29

  5. Marco Huber uploaded patch set 3 02/24/14, 15:39

  6. Mr. Jenkins commented on patch set 3 02/24/14, 15:52

  7. Marco Huber commented on patch set 3 02/24/14, 16:00

    My colleague was more creative than I, so the commit message title is shorter.
  8. Peter Kraume voted on patch set 3 V +1 CR +1 02/24/14, 16:04

  9. Benni Mack commented on patch set 3 02/24/14, 20:22

    Syntax seems a bit complicated. couldn't we do something like: config.additionalHeaders.Content-Type = attachment; config.additionalHeaders.Expires = never config.additionalHeaders.Expires.replaceExisting = 1 if you need to add something to an existing, you could always use something like config.additionalHeaders.Expires := addToList(never) ?
  10. Marco Huber commented on patch set 3 02/28/14, 09:24

    addToList adds the values commaseparated. But we don't know if every possible header field uses a comma to separate multiple values (at least I can't find anything in the RFC 2616).
  11. Marco Huber uploaded patch set 4 02/28/14, 10:13

  12. Mr. Jenkins commented on patch set 4 02/28/14, 10:27

  13. Marco Huber commented on patch set 4 03/11/14, 16:04

    It would be realy cool, if this one get's into 6.2. But I have no idea for a more simple solution.
  14. Mathias Schreiber wrote 12/17/14, 20:37

    Topic set to Typoscript
  15. Benni Mack uploaded patch set 5 12/31/14, 14:50

  16. Benni Mack voted on patch set 5 CR +1 V +1 12/31/14, 14:50

  17. Mathias Schreiber voted on patch set 5 CR +1 V +1 01/03/15, 17:06

  18. Anja Leichsenring voted on patch set 5 CR +2 V +2 01/03/15, 17:13

  19. Anja Leichsenring merged patch set 5 01/03/15, 17:13

  20. Helmut Hummel commented on patch set 5 01/04/15, 16:18

    TypoScriptFrontendController.php:3635

    these options are neither validated here nor checked for completeness. This potentially introduces PHP notices and there is no user feedback for wrong config. Not a big deal, since this is the case for almost any TS, but do we want it like that even for future features?