Review main Merged

27819[BUGFIX] Wrong file icon in info popup

Frans Saris CR +2 V +2 Easy +27 −3 updated 03/08/14, 16:31

Commit message

In the info popup of a file/folder the wrong icon is shown.

This patch changes it so IconUtility::getSpriteIconForResource()
is used and moves the rendering of the header to the
DocumentTemplate.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 12

  1. Frans Saris commented on patch set 1 02/24/14, 20:56

  2. Mr. Jenkins commented on patch set 1 CR -1 V -1 02/24/14, 21:08

  3. Wouter Wolters commented on patch set 1 02/24/14, 21:13

    DocumentTemplate.php:578

    double space in here, reported by Jenkin;)
  4. Frans Saris uploaded patch set 2 02/24/14, 21:16

  5. Frans Saris commented on patch set 1 02/24/14, 21:17

    DocumentTemplate.php:577

    missing spaces

    DocumentTemplate.php:578 Reply

    Done
  6. Wouter Wolters voted on patch set 2 CR +1 02/24/14, 21:21

  7. Mr. Jenkins commented on patch set 2 02/24/14, 21:29

  8. Frans Saris rebased onto patch set 2 02/28/14, 18:41

  9. Mr. Jenkins commented on patch set 3 02/28/14, 18:57

  10. Wouter Wolters voted on patch set 3 V +1 CR +1 03/08/14, 15:15

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 03/08/14, 16:31

  12. Christian Kuhn merged patch set 4 03/08/14, 16:31